Remove blanket ToGodot/FromGodot pointer impls -> specific ones for native structs instead

Author: Bromeon

godot-codegen/src/class_generator.rs

@@ -880,15 +880,52 @@ fn make_native_structure(
 
     let imports = util::make_imports();
     let fields = make_native_structure_fields(&structure.format, ctx);
+    let doc = format!("[`ToGodot`] and [`FromGodot`] are implemented for `*mut {class_name}` and `*const {class_name}`.");
 
     // mod re_export needed, because class should not appear inside the file module, and we can't re-export private struct as pub
     let tokens = quote! {
         #imports
+        use crate::builtin::meta::{GodotConvert, FromGodot, ToGodot};
 
+        /// Native structure; can be passed via pointer in APIs that are not exposed to GDScript.
+        ///
+        #[doc = #doc]
         #[repr(C)]
         pub struct #class_name {
             #fields
         }
+
+        impl GodotConvert for *mut #class_name {
+            type Via = i64;
+        }
+
+        impl ToGodot for *mut #class_name {
+            fn to_godot(&self) -> Self::Via {
+                *self as i64
+            }
+        }
+
+        impl FromGodot for *mut #class_name {
+            fn try_from_godot(via: Self::Via) -> Option<Self> {
+                Some(via as Self)
+            }
+        }
+
+        impl GodotConvert for *const #class_name {
+            type Via = i64;
+        }
+
+        impl ToGodot for *const #class_name {
+            fn to_godot(&self) -> Self::Via {
+                *self as i64
+            }
+        }
+
+        impl FromGodot for *const #class_name {
+            fn try_from_godot(via: Self::Via) -> Option<Self> {
+                Some(via as Self)
+            }
+        }
     };
     // note: TypePtr -> ObjectPtr conversion OK?
 

godot-core/src/builtin/meta/godot_convert/impls.rs

@@ -7,6 +7,10 @@
 use crate::builtin::meta::{impl_godot_as_self, FromGodot, GodotConvert, GodotType, ToGodot};
 use godot_ffi as sys;
 
+// The following ToGodot/FromGodot/Convert impls are auto-generated for each engine type, co-located with their definitions:
+// - enum
+// - const/mut pointer to native struct
+
 // ----------------------------------------------------------------------------------------------------------------------------------------------
 // Option
 
@@ -89,41 +93,6 @@ impl FromGodot for sys::VariantOperator {
     }
 }
 
-// ----------------------------------------------------------------------------------------------------------------------------------------------
-// Pointers
-
-impl<T> GodotConvert for *mut T {
-    type Via = i64;
-}
-
-impl<T> ToGodot for *mut T {
-    fn to_godot(&self) -> Self::Via {
-        *self as i64
-    }
-}
-
-impl<T> FromGodot for *mut T {
-    fn try_from_godot(via: Self::Via) -> Option<Self> {
-        Some(via as Self)
-    }
-}
-
-impl<T> GodotConvert for *const T {
-    type Via = i64;
-}
-
-impl<T> ToGodot for *const T {
-    fn to_godot(&self) -> Self::Via {
-        *self as i64
-    }
-}
-
-impl<T> FromGodot for *const T {
-    fn try_from_godot(via: Self::Via) -> Option<Self> {
-        Some(via as Self)
-    }
-}
-
 // ----------------------------------------------------------------------------------------------------------------------------------------------
 // Scalars