Skip to content

Commit 7da1762

Browse files
author
Rebecca Franks
authored
Merge pull request #13 from godaddy/feature/remove-dependency-on-experimental
Remove @ExperimentalGraphicsApi usage
2 parents 63854e8 + f246ce1 commit 7da1762

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

color-picker/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ publishing {
9898
publications.withType(MavenPublication::class) {
9999
groupId = "com.godaddy.android.colorpicker"
100100
artifactId = "compose-color-picker"
101-
version = "0.3.0"
101+
version = "0.3.1"
102102

103103
artifact(tasks["javadocJar"])
104104

color-picker/src/commonMain/kotlin/com/godaddy/android/colorpicker/AlphaBar.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import kotlin.math.floor
3030
* @param currentColor the initial color to set on the alpha bar.
3131
* @param onAlphaChanged the callback that is invoked when alpha value changes. 0 - 1.
3232
*/
33-
@ExperimentalGraphicsApi
3433
@Composable
3534
internal fun AlphaBar(
3635
modifier: Modifier = Modifier,

color-picker/src/commonMain/kotlin/com/godaddy/android/colorpicker/ClassicColorPicker.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import androidx.compose.ui.unit.dp
2525
* @param onColorChanged callback that is triggered when the color changes
2626
*
2727
*/
28-
@ExperimentalGraphicsApi
2928
@Composable
3029
fun ClassicColorPicker(
3130
modifier: Modifier = Modifier,

color-picker/src/commonMain/kotlin/com/godaddy/android/colorpicker/HsvColor.kt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,10 @@ data class HsvColor(
2929
val alpha: Float
3030
) {
3131

32-
@ExperimentalGraphicsApi
3332
fun toColor(): Color {
34-
return Color.hsv(hue, saturation, value, alpha)
33+
val hsv = HSV(hue, saturation, value, alpha)
34+
val rgb = hsv.toSRGB()
35+
return Color(rgb.redInt, rgb.greenInt, rgb.blueInt, rgb.alphaInt)
3536
}
3637

3738

color-picker/src/commonMain/kotlin/com/godaddy/android/colorpicker/SaturationValueArea.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import androidx.compose.ui.input.pointer.pointerInput
2121
import androidx.compose.ui.unit.IntSize
2222
import androidx.compose.ui.unit.dp
2323
import androidx.compose.ui.unit.toSize
24+
import com.github.ajalt.colormath.model.HSV
2425

2526
/**
2627
* Saturation Value area Component that invokes onSaturationValueChanged when the saturation or value is mutated.
@@ -30,7 +31,6 @@ import androidx.compose.ui.unit.toSize
3031
* @param onSaturationValueChanged the callback that is invoked when saturation or value component of the changes.
3132
* saturation, value both between 0 - 1.
3233
*/
33-
@ExperimentalGraphicsApi
3434
@Composable
3535
internal fun SaturationValueArea(
3636
modifier: Modifier = Modifier,
@@ -42,10 +42,12 @@ internal fun SaturationValueArea(
4242
}
4343

4444
val currentColorGradientBrush = remember(currentColor.hue) {
45+
val hsv = HSV(currentColor.hue, 1.0f, 1.0f)
46+
val rgb = hsv.toSRGB()
4547
Brush.horizontalGradient(
4648
listOf(
4749
Color(0xffffffff),
48-
Color.hsv(currentColor.hue, 1.0f, 1.0f)
50+
Color(rgb.redInt, rgb.greenInt, rgb.blueInt, rgb.alphaInt)
4951
)
5052
)
5153
}

0 commit comments

Comments
 (0)