Skip to content

Commit b6531f8

Browse files
authored
Merge pull request #1217 from gocd/dependabot/bundler/selenium-webdriver-4.29.1
Bump selenium-webdriver from 4.10.0 to 4.29.1
2 parents 6a8673e + 8b8584b commit b6531f8

File tree

3 files changed

+16
-9
lines changed

3 files changed

+16
-9
lines changed

Gemfile.lock

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,9 @@ GEM
122122
representable (~> 3.1)
123123
rubyzip (2.4.1)
124124
securerandom (0.4.1)
125-
selenium-webdriver (4.10.0)
125+
selenium-webdriver (4.29.1)
126+
base64 (~> 0.2)
127+
logger (~> 1.4)
126128
rexml (~> 3.2, >= 3.2.5)
127129
rubyzip (>= 1.2.2, < 3.0)
128130
websocket (~> 1.0)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ gauge install
3838
3939
```
4040
cd gocd
41-
./gradlew -PfastBuild build-platform:publishToMavenLocal plugin-infra:go-plugin-api:publishToMavenLocal plugin-infra:go-plugin-api-internal:publishToMavenLocal installers:versionFile
41+
./gradlew -PfastBuild publishToMavenLocal installers:versionFile
4242
```
4343
4444
3. Build GoCD plugins:

step_implementations/initialize.rb

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,18 @@
5757
Capybara.register_driver :selenium do |app|
5858
browser = (ENV['browser'] || 'firefox').to_sym
5959
config = case browser
60-
when :firefox
61-
options = ::Selenium::WebDriver::Firefox::Options.new
62-
options.args << "--headless" if RbConfig::CONFIG['host_os'] =~ /linux/
63-
{browser: browser, options: options}
64-
else
65-
{browser: browser}
66-
end
60+
when :firefox
61+
::Selenium::WebDriver::Firefox::Service.driver_path = `which geckodriver`.chomp
62+
options = ::Selenium::WebDriver::Firefox::Options.new
63+
options.args << "--headless" if RbConfig::CONFIG['host_os'] =~ /linux/
64+
{ browser: browser, options: options }
65+
else
66+
chromedriver_path = `which chromedriver`.chomp
67+
::Selenium::WebDriver::Chrome::Service.driver_path = chromedriver_path
68+
::Selenium::WebDriver::Chromium::Service.driver_path = chromedriver_path
69+
::Selenium::WebDriver::Edge::Service.driver_path = chromedriver_path
70+
{ browser: browser }
71+
end
6772
Capybara::Selenium::Driver.new(app, **config)
6873
end
6974

0 commit comments

Comments
 (0)