Remove unnecessary use of commons-io

Author: chadlwilson

build.gradle

@@ -64,7 +64,6 @@ dependencies {
     compileOnly project.deps.gocdPluginApi
     implementation group: 'com.google.code.gson', name: 'gson', version: '2.10.1'
     implementation group: 'org.apache.commons', name: 'commons-lang3', version: '3.12.0'
-    implementation group: 'commons-io', name: 'commons-io', version: '2.11.0'
     implementation group: 'io.fabric8', name: 'kubernetes-client', version: '5.12.4'
     implementation group: 'com.github.spullara.mustache.java', name: 'compiler', version: '0.9.10'
     implementation group: 'org.freemarker', name: 'freemarker', version: '2.3.32'

src/main/java/cd/go/contrib/elasticagent/KubernetesInstanceFactory.java

@@ -26,14 +26,15 @@
 import com.github.mustachejava.MustacheFactory;
 import io.fabric8.kubernetes.api.model.*;
 import io.fabric8.kubernetes.client.KubernetesClient;
-import org.apache.commons.io.FileUtils;
 import org.apache.commons.lang3.StringUtils;
 
-import java.io.File;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.StringReader;
 import java.io.StringWriter;
 import java.net.URL;
+import java.nio.file.Files;
+import java.nio.file.Path;
 import java.time.Instant;
 import java.time.format.DateTimeParseException;
 import java.util.*;
@@ -262,17 +263,16 @@ else if ("yaml".equalsIgnoreCase(fileType)) {
             throw new IllegalArgumentException("RemoteFileType value should be one of `json` or `yaml`.");
         }
 
-        File podSpecFile = new File(String.format("pod_spec_%s", UUID.randomUUID().toString()));
-        try {
-            FileUtils.copyURLToFile(new URL(fileToDownload), podSpecFile);
+        Path podSpecFile = Path.of(String.format("pod_spec_%s", UUID.randomUUID()));
+        try (InputStream downloadStream = new URL(fileToDownload).openStream()){
+            Files.copy(downloadStream, podSpecFile);
             LOG.debug(format("Finished downloading %s to %s", fileToDownload, podSpecFile));
-            String spec = FileUtils.readFileToString(podSpecFile, UTF_8);
+            String spec = Files.readString(podSpecFile, UTF_8);
             String templatizedPodSpec = getTemplatizedPodSpec(spec);
             elasticAgentPod = mapper.readValue(templatizedPodSpec, Pod.class);
             setPodNameIfNecessary(elasticAgentPod, spec);
-            FileUtils.deleteQuietly(podSpecFile);
+            Files.deleteIfExists(podSpecFile);
             LOG.debug(format("Deleted %s", podSpecFile));
-
         } catch (IOException e) {
             //ignore error here, handle this inside validate profile!
             LOG.error(e.getMessage());

src/test/java/cd/go/contrib/elasticagent/KubernetesAgentInstancesIntegrationTest.java

@@ -22,15 +22,12 @@
 import io.fabric8.kubernetes.client.KubernetesClient;
 import io.fabric8.kubernetes.client.dsl.MixedOperation;
 import io.fabric8.kubernetes.client.dsl.PodResource;
-import org.apache.commons.io.FileUtils;
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import org.mockito.ArgumentCaptor;
 import org.mockito.Mock;
 import org.mockito.stubbing.Answer;
 
-import java.io.File;
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
@@ -83,11 +80,6 @@ public void setUp() {
         settings = PluginSettingsMother.defaultPluginSettings();
     }
 
-    @AfterEach
-    public void tearDown() {
-        FileUtils.deleteQuietly(new File("pod_spec"));
-    }
-
     @Test
     public void shouldCreateKubernetesPodForCreateAgentRequest() {
         KubernetesInstance kubernetesInstance = kubernetesAgentInstances.create(createAgentRequest, settings, mockedPluginRequest, consoleLogAppender);