Remove getSimpleDateFormat() as it is equivalent to Instant's toString()

Author: brandonvin

src/main/java/cd/go/contrib/elasticagent/Constants.java

@@ -53,7 +53,6 @@ public interface Constants {
     String KUBERNETES_POD_KIND_LABEL_KEY = "kind";
     String KUBERNETES_POD_KIND_LABEL_VALUE = "kubernetes-elastic-agent";
     String KUBERNETES_POD_NAME_PREFIX = "k8s-ea";
-    String KUBERNETES_POD_CREATION_TIME_FORMAT = "yyyy-MM-dd'T'HH:mm:ss'Z'";
 
     String POD_POSTFIX = "POD_POSTFIX";
     String CONTAINER_POSTFIX = "CONTAINER_POSTFIX";

src/main/java/cd/go/contrib/elasticagent/KubernetesInstanceFactory.java

@@ -41,7 +41,6 @@
 import static cd.go.contrib.elasticagent.Constants.*;
 import static cd.go.contrib.elasticagent.KubernetesPlugin.LOG;
 import static cd.go.contrib.elasticagent.executors.GetProfileMetadataExecutor.*;
-import static cd.go.contrib.elasticagent.utils.Util.getSimpleDateFormat;
 import static java.lang.String.valueOf;
 import static java.nio.charset.StandardCharsets.UTF_8;
 import static java.text.MessageFormat.format;
@@ -104,7 +103,7 @@ private Boolean privileged(CreateAgentRequest request) {
     }
 
     private void setGoCDMetadata(CreateAgentRequest request, PluginSettings settings, PluginRequest pluginRequest, Pod elasticAgentPod) {
-        elasticAgentPod.getMetadata().setCreationTimestamp(getSimpleDateFormat().format(Instant.now()));
+        elasticAgentPod.getMetadata().setCreationTimestamp(Instant.now().toString());
 
         setContainerEnvVariables(elasticAgentPod, request, settings, pluginRequest);
         setAnnotations(elasticAgentPod, request);

src/main/java/cd/go/contrib/elasticagent/utils/Util.java

@@ -26,22 +26,14 @@
 import java.io.InputStream;
 import java.io.StringReader;
 import java.nio.charset.StandardCharsets;
-import java.time.ZoneOffset;
-import java.time.format.DateTimeFormatter;
 import java.util.Properties;
 
-import static cd.go.contrib.elasticagent.Constants.KUBERNETES_POD_CREATION_TIME_FORMAT;
-
 public class Util {
     public static final Gson GSON = new GsonBuilder()
             .setFieldNamingPolicy(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES)
             .excludeFieldsWithoutExposeAnnotation()
             .create();
 
-    public static DateTimeFormatter getSimpleDateFormat() {
-        return DateTimeFormatter.ofPattern(KUBERNETES_POD_CREATION_TIME_FORMAT).withZone(ZoneOffset.UTC);
-    }
-
     public static String readResource(String resourceFile) {
         return new String(readResourceBytes(resourceFile), StandardCharsets.UTF_8);
     }

src/test/java/cd/go/contrib/elasticagent/executors/ServerPingRequestExecutorTest.java

@@ -35,7 +35,6 @@
 import static java.time.temporal.ChronoUnit.MINUTES;
 
 import static cd.go.contrib.elasticagent.Constants.JOB_ID_LABEL_KEY;
-import static cd.go.contrib.elasticagent.utils.Util.getSimpleDateFormat;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.mockito.Mockito.*;
@@ -206,7 +205,7 @@ public void testShouldTerminateUnregisteredInstances_forSingleCluster() throws E
         objectMetadata = new ObjectMeta();
         objectMetadata.setLabels(Collections.singletonMap(JOB_ID_LABEL_KEY, "20"));
         objectMetadata.setName(unregisteredAgentId1);
-        objectMetadata.setCreationTimestamp(getSimpleDateFormat().format(Instant.now().minus(20, MINUTES)));
+        objectMetadata.setCreationTimestamp(Instant.now().minus(20, MINUTES).toString());
 
         when(mockedPod.getMetadata()).thenReturn(objectMetadata);