Fix #191 - default size units to bytes if not present

Author: chadlwilson

src/main/java/cd/go/contrib/elasticagent/utils/Size.java

@@ -27,7 +27,7 @@
 import static java.util.Objects.requireNonNull;
 
 public class Size implements Comparable<Size> {
-    private static final Pattern SIZE_PATTERN = Pattern.compile("(\\d+)\\s*(\\S+)");
+    private static final Pattern SIZE_PATTERN = Pattern.compile("(\\d+)\\s*(\\S*)");
 
     private static final Map<String, SizeUnit> SUFFIXES;
 
@@ -101,10 +101,11 @@ public static Size parse(String size) {
         }
 
         final double count = Double.parseDouble(matcher.group(1));
-        final SizeUnit unit = SUFFIXES.get(matcher.group(2));
-        if (unit == null) {
+        String suffix = matcher.group(2);
+        if (!suffix.isBlank() && !SUFFIXES.containsKey(suffix)) {
             throw new IllegalArgumentException("Invalid size: " + size + ". Wrong size unit");
         }
+        final SizeUnit unit = SUFFIXES.getOrDefault(suffix, SizeUnit.BYTES);
 
         return new Size(count, unit);
     }

src/test/java/cd/go/contrib/elasticagent/utils/SizeTest.java

@@ -37,11 +37,6 @@ public void shouldThrowExceptionIfTheGivenSizeHasDifferentSuffix() {
         assertThrows(IllegalArgumentException.class, () -> Size.parse("24000kig"));
     }
 
-    @Test
-    public void shouldThrowExceptionIfTheGivenSizeHasNoUint() {
-        assertThrows(IllegalArgumentException.class, () -> Size.parse("24000"));
-    }
-
     @Test
     public void shouldThrowExceptionIfTheGivenSizeIsNull() {
         assertThrows(IllegalArgumentException.class, () -> Size.parse(null));
@@ -57,6 +52,12 @@ public void fromQuantity() {
         assertEquals("58 GB", Size.fromQuantity(Quantity.parse("58Gi")).readableSize());
     }
 
+    @Test
+    public void defaultSizeUnitIsBytes() {
+        Size oneKB = Size.parse("1024");
+        assertEquals(oneKB.toBytes(), 1024, 0);
+    }
+
     @Test
     public void toBytes() {
         Size oneKB = Size.parse("1Ki");