Merge pull request #883 from gobitfly/BEDS-514/appsub-fail-metrics

Add metrics when app sub verification fails

Author: manuelsc

backend/pkg/api/handlers/auth.go

@@ -14,6 +14,7 @@ import (
 	"github.com/gobitfly/beaconchain/pkg/api/types"
 	"github.com/gobitfly/beaconchain/pkg/commons/log"
 	"github.com/gobitfly/beaconchain/pkg/commons/mail"
+	"github.com/gobitfly/beaconchain/pkg/commons/metrics"
 	commonTypes "github.com/gobitfly/beaconchain/pkg/commons/types"
 	"github.com/gobitfly/beaconchain/pkg/commons/utils"
 	"github.com/gobitfly/beaconchain/pkg/userservice"
@@ -708,6 +709,7 @@ func (h *HandlerService) InternalHandleMobilePurchase(w http.ResponseWriter, r *
 	validationResult, err := userservice.VerifyReceipt(nil, nil, verifyPackage)
 	if err != nil {
 		log.Warn(err, "could not verify receipt %v", 0, map[string]interface{}{"receipt": verifyPackage.Receipt})
+		metrics.Errors.WithLabelValues(fmt.Sprintf("appsub_verify_%s_failed", req.Transaction.Type)).Inc()
 		if errors.Is(err, userservice.ErrClientInit) {
 			log.Error(err, "Apple or Google client is NOT initialized. Did you provide their configuration?", 0, nil)
 			handleErr(w, r, err)

backend/pkg/userservice/appsubscription_oracle.go

@@ -11,6 +11,7 @@ import (
 
 	"github.com/gobitfly/beaconchain/pkg/commons/db"
 	"github.com/gobitfly/beaconchain/pkg/commons/log"
+	"github.com/gobitfly/beaconchain/pkg/commons/metrics"
 	"github.com/gobitfly/beaconchain/pkg/commons/types"
 	"github.com/gobitfly/beaconchain/pkg/commons/utils"
 
@@ -37,18 +38,21 @@ func CheckMobileSubscriptions() {
 		receipts, err := db.GetAllAppSubscriptions()
 
 		if err != nil {
+			metrics.Errors.WithLabelValues("appsub_verify_db_failed").Inc()
 			log.Error(err, "error retrieving subscription data from db: %v", 0, nil)
 			return
 		}
 
 		googleClient, err := initGoogle()
 		if googleClient == nil {
+			metrics.Errors.WithLabelValues("appsub_verify_initgoogle_failed").Inc()
 			log.Error(err, "error initializing google client: %v", 0, nil)
 			return
 		}
 
 		appleClient, err := initApple()
 		if err != nil {
+			metrics.Errors.WithLabelValues("appsub_verify_initapple_failed").Inc()
 			log.Error(err, "error initializing apple client: %v", 0, nil)
 			return
 		}
@@ -71,11 +75,14 @@ func CheckMobileSubscriptions() {
 				if strings.Contains(err.Error(), "expired") {
 					err = db.SetSubscriptionToExpired(nil, receipt.ID)
 					if err != nil {
+						metrics.Errors.WithLabelValues("appsub_verify_write_failed").Inc()
 						log.Error(err, "subscription set expired failed", 0, map[string]interface{}{"receiptID": receipt.ID})
 					}
 					continue
 				}
 				log.Warnf("subscription verification failed in service for [%v]: %v", receipt.ID, err)
+				metrics.Errors.WithLabelValues(fmt.Sprintf("appsub_verify_%s_failed", receipt.Store)).Inc()
+
 				continue
 			}