Skip to content

Commit c17ca37

Browse files
authored
chore: update linter (#2341)
1 parent a7aaae4 commit c17ca37

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
env:
1515
GO_VERSION: stable
16-
GOLANGCI_LINT_VERSION: v1.60.1
16+
GOLANGCI_LINT_VERSION: v1.62.0
1717
HUGO_VERSION: 0.131.0
1818
CGO_ENABLED: 0
1919
LEGO_E2E_TESTS: CI

.golangci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
linters:
22
enable-all: true
33
disable:
4-
- gomnd # deprecated
54
- cyclop # duplicate of gocyclo
65
- sqlclosecheck # not relevant (SQL)
76
- rowserrcheck # not relevant (SQL)
8-
- execinquery # not relevant (SQL)
97
- lll
108
- gosec
119
- dupl # not relevant
@@ -255,6 +253,10 @@ issues:
255253
text: 'cyclomatic complexity 13 of func `\(\*DNSProvider\)\.CleanUp` is high'
256254
linters:
257255
- gocyclo
256+
- path: providers/dns/servercow/internal/types.go
257+
text: 'the methods of "Value" use pointer receiver and non-pointer receiver.'
258+
linters:
259+
- recvcheck
258260

259261
# Those elements have been replaced by non-exposed structures.
260262
- path: providers/dns/linode/linode_test.go

providers/dns/auroradns/auroradns_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ func TestDNSProvider_Present(t *testing.T) {
163163

164164
reqBody, err := io.ReadAll(r.Body)
165165
require.NoError(t, err)
166-
assert.Equal(t, `{"type":"TXT","name":"_acme-challenge","content":"w6uP8Tcg6K2QR905Rms8iXTlksL6OD1KOWBxTK7wxPI","ttl":300}`, string(reqBody))
166+
assert.JSONEq(t, `{"type":"TXT","name":"_acme-challenge","content":"w6uP8Tcg6K2QR905Rms8iXTlksL6OD1KOWBxTK7wxPI","ttl":300}`, string(reqBody))
167167

168168
w.WriteHeader(http.StatusCreated)
169169
fmt.Fprintf(w, `{

0 commit comments

Comments
 (0)