refactor: streamline stdin handling in CLI and enhance file path resolution

- Updated CLI to always attempt conversion of stdin content, with error handling for empty input.
- Resolved source directory paths to absolute in `convertDirectory` for consistent file handling.
- Adjusted test cases to reflect changes in stdin processing and ensure accurate error reporting.

Author: gmickel

src/cli.ts

@@ -130,19 +130,14 @@ program
             chunks.push(chunk);
           }
           const stdinContent = Buffer.concat(chunks).toString('utf-8');
-          if (stdinContent) {
-            // Call convertString with forceFormat as the 3rd argument
-            const convertedContent = convertString(
-              stdinContent,
-              direction,
-              forceFormat
-            );
-            process.stdout.write(convertedContent);
-          } else {
-            // Handle empty stdin case if necessary, maybe show help?
-            program.help({ error: true }); // Show help if stdin is empty
-            // NOTE: program.help({ error: true }) should exit, but we add else for clarity
-          }
+          // Always attempt conversion. convertString will throw E01 for empty string,
+          // which will be caught below and handled by exitWithError.
+          const convertedContent = convertString(
+            stdinContent,
+            direction,
+            forceFormat
+          );
+          process.stdout.write(convertedContent);
         } catch (e) {
           // Handle errors during stdin read or conversion
           if (e instanceof ConversionError) {

src/index.ts

@@ -1,5 +1,13 @@
 import { mkdir, readFile, stat, writeFile } from 'node:fs/promises';
-import { basename, dirname, extname, join, parse, relative } from 'node:path';
+import {
+  basename,
+  dirname,
+  extname,
+  join,
+  parse,
+  relative,
+  resolve,
+} from 'node:path';
 import fastGlob from 'fast-glob';
 import { convertRuleContent, detectFormat } from './mapper';
 import {
@@ -230,18 +238,21 @@ export async function convertDirectory(
   }
 
   // Glob for both .md and .mdc files
-  const globPattern = join(sourceDir, '**/*.{md,mdc}');
+  const absoluteSourceDir = resolve(sourceDir); // Resolve to absolute path
+  const globPattern = join(absoluteSourceDir, '**/*.{md,mdc}');
   const potentialFiles = await fastGlob(globPattern, {
     onlyFiles: true,
     dot: true,
+    absolute: true, // Ensure fastGlob returns absolute paths
   });
 
   if (potentialFiles.length === 0) {
     return [];
   }
 
   for (const sourceFilePath of potentialFiles) {
-    const relativePath = relative(sourceDir, sourceFilePath);
+    // sourceFilePath is now absolute, ensure relativePath calculation is correct
+    const relativePath = relative(absoluteSourceDir, sourceFilePath);
     const parsedSourcePath = parse(sourceFilePath);
 
     let fileSpecificDirection: ConversionDirection | undefined =

test/index.test.ts

@@ -517,38 +517,42 @@ describe('CLI (cuws)', () => {
     });
 
     it('should convert stdin to stdout', async () => {
-      // Use exec directly for piping stdin
-      const command = `echo "${windsurfManualContent.replace(/"/g, '\\"')}" | node "${path.resolve(cliPath)}" -r`;
       const { stdout, stderr, exitCode } = await new Promise<{
         stdout: string;
         stderr: string;
         exitCode: number | null;
       }>((resolve) => {
-        const child = exec(command);
+        const child = exec(`node "${path.resolve(cliPath)}" -r`, {
+          env: { ...process.env },
+        });
         let stdoutData = '';
         let stderrData = '';
+
         child.stdout?.on('data', (data) => {
           stdoutData += data;
         });
         child.stderr?.on('data', (data) => {
           stderrData += data;
         });
-        child.on('close', (code) =>
-          resolve({ stdout: stdoutData, stderr: stderrData, exitCode: code })
-        );
-        child.on('error', (err) =>
+        child.on('close', (code) => {
+          resolve({ stdout: stdoutData, stderr: stderrData, exitCode: code });
+        });
+        child.on('error', (err) => {
           resolve({
             stdout: stdoutData,
             stderr: stderrData + err.message,
             exitCode: 1,
-          })
-        );
+          });
+        });
+
+        // Write to stdin
+        child.stdin?.write(windsurfManualContent);
+        child.stdin?.end();
       });
 
       expect(stderr).toBe('');
       expect(exitCode).toBe(0);
-      // Trim stdout because echo might add a newline
-      expect(stdout.trim()).toEqual(expectedCursorManualContent.trim()); // Use expectedCursorManualContent
+      expect(stdout.trim()).toEqual(expectedCursorManualContent.trim());
     });
 
     it('should convert file input to stdout (using -i without -o)', async () => {
@@ -564,35 +568,40 @@ describe('CLI (cuws)', () => {
     });
 
     it('should show help if stdin is empty', async () => {
-      // Use exec directly for piping stdin
-      const command = `echo "" | node "${path.resolve(cliPath)}" -r`;
-      const { stderr, exitCode } = await new Promise<{
+      const { stdout, stderr, exitCode } = await new Promise<{
         stdout: string;
         stderr: string;
         exitCode: number | null;
       }>((resolve) => {
-        const child = exec(command);
+        const child = exec(`node "${path.resolve(cliPath)}" -r`, {
+          env: { ...process.env },
+        });
         let stdoutData = '';
         let stderrData = '';
+
         child.stdout?.on('data', (data) => {
           stdoutData += data;
         });
         child.stderr?.on('data', (data) => {
           stderrData += data;
         });
-        child.on('close', (code) =>
-          resolve({ stdout: stdoutData, stderr: stderrData, exitCode: code })
-        );
-        child.on('error', (err) =>
+        child.on('close', (code) => {
+          resolve({ stdout: stdoutData, stderr: stderrData, exitCode: code });
+        });
+        child.on('error', (err) => {
           resolve({
             stdout: stdoutData,
             stderr: stderrData + err.message,
             exitCode: 1,
-          })
-        );
+          });
+        });
+
+        // Write empty string to stdin and close it
+        child.stdin?.write('');
+        child.stdin?.end();
       });
 
-      // Expect the specific error message printed by program.help({ error: true })
+      // Expect the specific error message
       expect(stderr).toContain(
         'Error (E01): Could not determine source format.'
       );