-
Notifications
You must be signed in to change notification settings - Fork 21
Open
Description
Currently, mikktspace has an nalgebra
feature (enabled by default) and a glam
feature. This is discouraged as it means two libraries each depending on mikktspace might be incompatible with each other with no way for a user to fix it.
We ran into that incompatibility in our game, where the main game was depending on mikktspace with
mikktspace = { version = "0.3.0", default-features = false, features = ["glam"] }
but a crate that we depended on used
mikktspace = "0.3.0"
...causing a compilation error in mikktspace.
There are two pretty good approaches to solve this issue generally:
- Pick a single math library to use internally. This can help with maintainability. Math libraries, especially glam, aren't too heavy on compilation times so this might not be so bad.
- Inline the math functions into the crate. It looks like Manual refactoring #23 is a step in that direction.
Metadata
Metadata
Assignees
Labels
No labels