Setup phpstan with Safe-PHP (#19689)

* Setup phpstan with Safe-PHP

see https://github.com/thecodingmachine/safe

* Add all errors to baseline

* Fix an issue to prevent unused dependency issue

* Error differs depending on PHP versions

---------

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>

Author: trasher

.phpstan-baseline.8.2-8.3.php

@@ -0,0 +1,21 @@
+<?php declare(strict_types = 1);
+
+if (preg_match('/^8\.4\./', PHP_VERSION) !== 1) {
+    return ['parameters' => ['ignoreErrors' => []]];
+}
+
+/*
+ * The following error will occur only on PHP 8.4.
+ * Unfortunately, it is not possible to ignore it using a @phpstan-ignore, so we have to handle it here.
+ */
+
+$ignoreErrors = [];
+
+$ignoreErrors[] = [
+	'message' => '#^Function openssl_pkey_get_details is unsafe to use\\. It can return FALSE instead of throwing an exception\\. Please add \'use function Safe\\\\openssl_pkey_get_details;\' at the beginning of the file to use the variant provided by the \'thecodingmachine/safe\' library\\.$#',
+	'identifier' => 'theCodingMachineSafe.function',
+	'count' => 1,
+	'path' => __DIR__ . '/src/Glpi/OAuth/Server.php',
+];
+
+return ['parameters' => ['ignoreErrors' => $ignoreErrors]];

.phpstan-baseline.8.4.php

@@ -33,6 +33,8 @@
  * ---------------------------------------------------------------------
  */
 
+use function Safe\json_encode;
+
 if (isset($_POST['regenerate_backup_codes'])) {
     $totp = new \Glpi\Security\TOTPManager();
     $codes = $totp->regenerateBackupCodes(Session::getLoginUserID());

.phpstan-baseline.php

@@ -94,6 +94,7 @@
         "symfony/serializer": "^7.1",
         "tecnickcom/tc-lib-barcode": "^2.4",
         "tecnickcom/tcpdf": "^6.9",
+        "thecodingmachine/safe": "^3.1",
         "thenetworg/oauth2-azure": "^2.2",
         "twig/markdown-extra": "^3.20",
         "twig/string-extra": "^3.20",
@@ -122,7 +123,8 @@
         "symfony/stopwatch": "^6.4",
         "symfony/twig-bundle": "^6.4",
         "symfony/var-dumper": "^6.4",
-        "symfony/web-profiler-bundle": "^6.4"
+        "symfony/web-profiler-bundle": "^6.4",
+        "thecodingmachine/phpstan-safe-rule": "^1.4"
     },
     "provide": {
         "ext-sodium": "*"

ajax/2fa.php

@@ -1,5 +1,7 @@
 includes:
     - .phpstan-baseline.php
+    - .phpstan-baseline.8.2-8.3.php
+    - .phpstan-baseline.8.4.php
 
 parameters:
     level: 4