Fix ticket title/description edition (#19727)

* Fix ticket title/description edition

* Apply suggestions from code review

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>

* Fix typo

---------

Co-authored-by: Cédric Anne <cedric.anne@gmail.com>

Author: AdrienClairembault

phpunit/functional/TicketTest.php

@@ -8680,4 +8680,31 @@ public function testConditionalSearchOptions()
         SearchOption::clearSearchOptionCache(Ticket::class);
         $this->assertArrayNotHasKey('111', SearchOption::getCleanedOptions(Ticket::class));
     }
+
+    public function testShowSubForm(): void
+    {
+        // Arrange: create a ticket
+        $ticket = $this->createItem(Ticket::class, [
+            'name' => 'My ticket',
+            'content' => 'My content',
+            'entities_id' => $this->getTestRootEntity(only_id: true),
+        ]);
+
+        // Act: render sub form for this ticket
+        $this->login();
+        ob_start();
+        Ticket::showSubForm($ticket, $ticket->getId(), [
+            // Note: these parameters are ugly (ticket is both the target and
+            // the parent somehow) but this is how its called from the actual
+            // front files so we need to replicate it.
+            'parent' => $ticket,
+            'tickets_id' => $ticket->getID(),
+        ]);
+        $html = ob_get_clean();
+
+        // Assert: make sure some html was generated
+        $crawler = new Crawler($html);
+        $this->assertCount(1, $crawler->filter('input[name="name"]'));
+        $this->assertCount(1, $crawler->filter('textarea[name="content"]'));
+    }
 }

templates/components/form/basic_inputs_macros.html.twig

@@ -382,7 +382,7 @@
         </script>
     {% endif %}
 
-    {% if options.mention_options.enabled and config('use_notifications') %}
+    {% if options.mention_options.enabled|default(false) and config('use_notifications') %}
         <script>
             $(function() {
                 const user_mention = new GLPI.RichText.UserMention(

templates/components/form/fields_macros.html.twig

@@ -797,7 +797,7 @@
       {% set field = field|replace({'%id%': id}) %}
       {% set add_field_html = options.add_field_html|length > 0 ? options.add_field_html : '' %}
 
-      {% if options.fields_template is not defined or not options.fields_template.isHiddenField(name) %}
+      {% if not options.fields_template.isHiddenField(name)|default(false) %}
          {% if options.no_label %}
             {{ _self.noLabelField(field, id, add_field_html, options) }}
          {% elseif options.is_horizontal %}

templates/components/itilobject/timeline/simple_form.html.twig

@@ -39,7 +39,7 @@
 {% set field_options = {
    'is_horizontal': false,
    'full_width': true,
-   'fields_template': itiltemplate,
+   'fields_template': itiltemplate|default(null),
    'disabled': (not (canupdate or can_requester)),
 } %}
 
@@ -86,8 +86,8 @@
          __('Description'),
          field_options|merge({
             'enable_richtext': true,
-            'enable_fileupload': (itiltemplate.isHiddenField('_documents_id')) ? false : true,
-            'mention_options': mention_options,
+            'enable_fileupload': itiltemplate.isHiddenField('_documents_id')|default(false) ? false : true,
+            'mention_options': mention_options|default({}),
             'entities_id': item.isNewItem() ? entities_id : item.fields['entities_id'],
             'uploads': uploads,
             'add_field_class': 'col-12 itil-textarea-content',