feat: update tests for checking cookie rotation when login or remember token is used

Author: novacuum

framework/core/tests/integration/forum/LoginTest.php

@@ -9,10 +9,15 @@
 
 namespace Flarum\Tests\integration\forum;
 
+use Dflydev\FigCookies\FigResponseCookies;
 use Flarum\Extend;
 use Flarum\Http\AccessToken;
+use Flarum\Http\CookieFactory;
+use Flarum\Http\RememberAccessToken;
+use Flarum\Http\Rememberer;
 use Flarum\Testing\integration\RetrievesAuthorizedUsers;
 use Flarum\Testing\integration\TestCase;
+use Illuminate\Support\Str;
 
 class LoginTest extends TestCase
 {
@@ -70,16 +75,25 @@ public function cant_login_with_wrong_password()
      */
     public function can_login_with_data()
     {
+        $id = Str::random(40);
+        $this->app();
+        $cookieFactory = resolve(CookieFactory::class);
+        $sessionCookieName = $cookieFactory->getName('session');
+
         $response = $this->send(
             $this->request('POST', '/login', [
                 'json' => [
                     'identification' => 'normal',
                     'password' => 'too-obscure'
                 ]
+            ])->withCookieParams([
+                $sessionCookieName => $id
             ])
         );
 
         $this->assertEquals(200, $response->getStatusCode());
+        $cookie = FigResponseCookies::get($response, $sessionCookieName);
+        $this->assertNotEquals($id, $cookie->getValue());
 
         // The response body should contain the user ID...
         $body = (string) $response->getBody();
@@ -92,4 +106,28 @@ public function can_login_with_data()
         $token = $data['token'];
         $this->assertEquals(2, AccessToken::whereToken($token)->firstOrFail()->user_id);
     }
+
+    /**
+     * @test
+     */
+    public function can_login_with_remember_token()
+    {
+        $this->app();
+        $rememberToken = RememberAccessToken::generate(1);
+        $id = Str::random(40);
+        $cookieFactory = resolve(CookieFactory::class);
+        $sessionCookieName = $cookieFactory->getName('session');
+        $rememberCookieName = $cookieFactory->getName(Rememberer::COOKIE_NAME);
+
+        $response = $this->send(
+            $this->request('GET', '/settings')->withCookieParams([
+                $sessionCookieName => $id,
+                $rememberCookieName => $rememberToken->token
+            ])
+        );
+
+        $this->assertEquals(200, $response->getStatusCode());
+        $cookie = FigResponseCookies::get($response, $sessionCookieName);
+        $this->assertNotEquals($id, $cookie->getValue());
+    }
 }