inconsistent doc for Registry

[alekc]

Given this config

apiVersion: registry.harbor.crossplane.io/v1alpha1
kind: Registry
metadata:
  name: dockerhub
spec:
#  providerConfigRef:
#    name: ${provider_name}
  forProvider:
    providerName: ${provider_name}
    name: docker.io
    accessId: xx
    accessSecretSecretRef:
      key: "docker.io"
      name: docker-registries
      namespace: harbor

It was giving following error

one or more objects failed to apply, reason: Registry.registry.harbor.crossplane.io "dockerhub" is invalid: spec: Invalid value: "object": spec.forProvider.endpointUrl is a required parameter (retried 5 times).

Its not marked as required on doc

[lornest]

Interesting. This seems to be a quirk with the way Upjet implements the 'required-ness' of a field. The endpoint_url Terraform field is required, but in the generated CRD I can see endpointUrl is not "required", but there is the following Kubernetes validation:

x-kubernetes-validations:
- message: spec.forProvider.endpointUrl is a required parameter
  rule: '!(''*'' in self.managementPolicies || ''Create'' in self.managementPolicies || ''Update'' in self.managementPolicies) || has(self.forProvider.endpointUrl) || (has(self.initProvider) && has(self.initProvider.endpointUrl))'

So endpointUrl is conditionally required if managementPolicies includes "*", "Create", or "Update".

I'm not sure why that's the case, will do some digging.