Skip to content

Commit d5b1f14

Browse files
committed
Update comments, credit, colors
1 parent df2380b commit d5b1f14

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

example/materialDatabase.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { MaterialOrbSceneLoader } from './utils/MaterialOrbSceneLoader.js';
1313
import { RectAreaLightUniformsLib } from 'three/examples/jsm/lights/RectAreaLightUniformsLib.js';
1414

1515
const DB_URL = 'https://api.physicallybased.info/materials';
16-
const CREDITS = 'Materials courtesy of "physicallybased.info"</br>Material orb courtesy of USD Working Group';
16+
const CREDITS = 'Materials courtesy of "physicallybased.info"</br>Material orb model courtesy of USD Working Group';
1717

1818
let pathTracer, renderer, controls, material;
1919
let camera, database, scene;

example/utils/MaterialOrbSceneLoader.js

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
1-
import { MeshPhysicalMaterial, RectAreaLight, SRGBColorSpace } from 'three';
1+
import { MeshPhysicalMaterial, RectAreaLight } from 'three';
22
import { GLTFLoader } from 'three/examples/jsm/loaders/GLTFLoader.js';
33

44
// TODO: this scene should technically be rendered at a 1000x smaller scale
5-
// TODO: it would be nice to round the orb 3d model a bit more
65

76
const ORB_SCENE_URL = 'https://raw.githubusercontent.com/gkjohnson/3d-demo-data/main/models/usd-shader-ball/usd-shaderball-scene.glb';
87
function assignWatts( light, watts ) {
@@ -60,13 +59,6 @@ export class MaterialOrbSceneLoader {
6059

6160
}
6261

63-
// TODO: this should be colored by a texture that says "Sub-Surface Bar"
64-
if ( c.name === 'sss_bars' ) {
65-
66-
c.material.color.setRGB( 0.01, 0.01, 0.01, SRGBColorSpace );
67-
68-
}
69-
7062
} );
7163

7264
const material = new MeshPhysicalMaterial();

0 commit comments

Comments
 (0)