From 9b59f3d082cfe1302df03c9f3d073f0ea90bdbae Mon Sep 17 00:00:00 2001 From: Bryan Behrenshausen Date: Thu, 18 Apr 2024 10:57:54 -0400 Subject: [PATCH 1/2] add : to signoff trailer --- src/popups/commit.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/popups/commit.rs b/src/popups/commit.rs index 9bd4806989..0b9a1958fe 100644 --- a/src/popups/commit.rs +++ b/src/popups/commit.rs @@ -470,7 +470,7 @@ impl CommitPopup { let mut msg = msg.to_owned(); if let (Some(user), Some(mail)) = (user, mail) { msg.push_str(&format!( - "\n\nSigned-off-by {user} <{mail}>" + "\n\nSigned-off-by: {user} <{mail}>" )); } From ba9e4873d4360d4bcd8c8f09f11750cee62e5ecd Mon Sep 17 00:00:00 2001 From: Bryan Behrenshausen Date: Mon, 22 Apr 2024 09:31:17 -0400 Subject: [PATCH 2/2] Add item to changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 271cfcfe16..1694504e09 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Unreleased +* add `:` character to sign-off trailer to comply with Conventinoal Commits standard [@semioticrobotic](https://github.com/semioticrobotic) [#2196](https://github.com/extrawurst/gitui/issues/2196) + ## [0.26.0+1] - 2024-04-14 **0.26.1**