add isRename and isChangeMode on a diff File

Author: alexandresalome

doc/api/diff.rst

@@ -42,7 +42,7 @@ modifications for a single file.
 The File object
 ---------------
 
-Here is an exhaustive list of the *File* object:
+Here is an exhaustive list of the *File* class methods:
 
 .. code-block:: php
 
@@ -51,8 +51,12 @@ Here is an exhaustive list of the *File* object:
     $file->getOldDiff();
     $file->getNewDiff();
 
-    $file->isNew(); // Indicates file was created
-    $file->isDelete(); // Indicates file was deleted
+    $file->isCreation();
+    $file->isDeletion();
+    $file->isModification();
+
+    $file->isRename();
+    $file->isChangeMode();
 
     $file->getAdditions(); // Number of added lines
     $file->getDeletions(); // Number of deleted lines

src/Gitonomy/Git/Diff/File.php

@@ -105,6 +105,26 @@ public function isModification()
         return null !== $this->oldName && null !== $this->newName;
     }
 
+    /**
+     * Indicates if it's a rename.
+     *
+     * A rename can only occurs if it's a modification (not a creation or a deletion).
+     *
+     * @return boolean
+     */
+    public function isRename()
+    {
+        return $this->isModification() && $this->oldName !== $this->newName;
+    }
+
+    /**
+     * Indicates if the file mode has changed.
+     */
+    public function isChangeMode()
+    {
+        return $this->isModification() && $this->oldMode !== $this->newMode;
+    }
+
     /**
      * Indicates if this diff file is a deletion.
      *

tests/Gitonomy/Git/Tests/DiffTest.php

@@ -16,8 +16,10 @@
 
 class DiffTest extends AbstractTest
 {
-    const DELETE_COMMIT = '519d5693c72c925cd59205d9f11e9fa1d550028b';
-    const CREATE_COMMIT = 'e6fa3c792facc06faa049a6938c84c411954deb5';
+    const DELETE_COMMIT     = '519d5693c72c925cd59205d9f11e9fa1d550028b';
+    const CREATE_COMMIT     = 'e6fa3c792facc06faa049a6938c84c411954deb5';
+    const RENAME_COMMIT     = '6640e0ef31518054847a1876328e26ee64083e0a';
+    const CHANGEMODE_COMMIT = '93da965f58170f13017477b9a608657e87e23230';
 
     /**
      * @dataProvider provideFoobar
@@ -91,6 +93,38 @@ public function testGetFiles_Deletion($repository)
         $this->assertEquals(1, $files[0]->getDeletions(), "1 line deleted");
     }
 
+    /**
+     * @dataProvider provideFoobar
+     */
+    public function testGetFiles_Rename($repository)
+    {
+        $files = $repository->getCommit(self::RENAME_COMMIT)->getDiff()->getFiles();
+
+        $this->assertEquals(1, count($files), "1 files modified");
+
+        $this->assertTrue($files[0]->isModification());
+        $this->assertTrue($files[0]->isRename());
+        $this->assertFalse($files[0]->isDeletion());
+        $this->assertFalse($files[0]->isCreation());
+        $this->assertFalse($files[0]->isChangeMode());
+    }
+
+    /**
+     * @dataProvider provideFoobar
+     */
+    public function testGetFiles_Changemode($repository)
+    {
+        $files = $repository->getCommit(self::CHANGEMODE_COMMIT)->getDiff()->getFiles();
+
+        $this->assertEquals(1, count($files), "1 files modified");
+
+        $this->assertTrue($files[0]->isModification());
+        $this->assertTrue($files[0]->isChangeMode());
+        $this->assertFalse($files[0]->isDeletion());
+        $this->assertFalse($files[0]->isCreation());
+        $this->assertFalse($files[0]->isRename());
+    }
+
     /**
      * @dataProvider provideFoobar
      */