Tab double click and renaming

[pylessard]

Hi,
For my use case, I would like to have 2 behaviours:

1. Do not make a dockwidget floating when double-clicking the tab
2. Allow renaming a tab

For 1. I think a simple flag to disable the event would be enough
For 2, I see 2 options:
a. Fully implemented within this project
b. Add a hook to enable custom QActions inside the context menu of a right click. Then I could add a Rename option that pops a window.

I can make a Pull Request fort 1. and 2.b. Would you be open for it?

[githubuser0xFFFF]

Hi, I just added a new config flag to master to enable / disable undocking on double-click. So if you want to implement point 2, feel free to create a pull request.

[pylessard]

Thanks, will see what I can do.
Do you have a preference on the approach? Native renaming or extensible menu and let the user handle?

[githubuser0xFFFF]

Extensible menu would be nice and a more generic solution for more users so I would prefer this.

[studiofuga]

@pylessard have a look to the latest changes involving the popup menu, specifically commit f237863 and the MyDockAreaTitleBar class in the demo subdirectory. IIUC, that should help you with the implementation.

[pylessard]

Thanks, will have a look. I am focusing on something else right now. But when the time comes, I will consider this

[pylessard]

Altough this issue is closed, I have opened a PR to enable custom contextmenu extension. See #742

Adding custom action could have been possible with a custom component factory, the solution i'm proposing allow per-dock widget features and also is more future-proof for the users as the context menu coming from the library can be extended instead of rebuilt from scratch with a duplicated logic.