Fixed crash caused by unparented widgets after restoring layout. (#724)

obsgolem · web-flow · commit c305432ab23a · 2025-03-07T08:52:48.000+01:00
This is essentially due to `setDockArea` undoing the earlier
`setParent`.
diff --git a/src/DockWidget.cpp b/src/DockWidget.cpp
@@ -841,9 +841,9 @@ void CDockWidget::saveState(QXmlStreamWriter& s) const
 void CDockWidget::flagAsUnassigned()
 {
 	d->Closed = true;
-	setParent(d->DockManager);
 	setVisible(false);
 	setDockArea(nullptr);
+	setParent(d->DockManager);
 	tabWidget()->setParent(this);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -841,9 +841,9 @@ void CDockWidget::saveState(QXmlStreamWriter& s) const`
`841`	`841`	`void CDockWidget::flagAsUnassigned()`
`842`	`842`	`{`
`843`	`843`	`d->Closed = true;`
`844`		`- setParent(d->DockManager);`
`845`	`844`	`setVisible(false);`
`846`	`845`	`setDockArea(nullptr);`
	`846`	`+ setParent(d->DockManager);`
`847`	`847`	`tabWidget()->setParent(this);`
`848`	`848`	`}`
`849`	`849`