Avoid multiple function calls of parentWidget() function in CAutoHideSideBar::visibleTabCount() and CAutoHideSideBar::hasVisibleTabs()

githubuser0xFFFF · githubuser0xFFFF · commit 85f65b3f1ae3 · 2023-06-23T10:21:08.000+02:00
diff --git a/src/AutoHideSideBar.cpp b/src/AutoHideSideBar.cpp
@@ -319,9 +319,10 @@ int CAutoHideSideBar::tabCount() const
 int CAutoHideSideBar::visibleTabCount() const
 {
 	int count = 0;
+	auto ParentWidget = parentWidget();
 	for (auto i = 0; i < tabCount(); i++)
 	{
-		if (tabAt(i)->isVisibleTo(parentWidget()))
+		if (tabAt(i)->isVisibleTo(ParentWidget))
 		{
 			count++;
 		}
@@ -334,9 +335,10 @@ int CAutoHideSideBar::visibleTabCount() const
 //============================================================================
 bool CAutoHideSideBar::hasVisibleTabs() const
 {
+	auto ParentWidget = parentWidget();
 	for (auto i = 0; i < tabCount(); i++)
 	{
-		if (tabAt(i)->isVisibleTo(parentWidget()))
+		if (tabAt(i)->isVisibleTo(ParentWidget))
 		{
 			return true;
 		}

Original file line number	Diff line number	Diff line change
`@@ -319,9 +319,10 @@ int CAutoHideSideBar::tabCount() const`
`319`	`319`	`int CAutoHideSideBar::visibleTabCount() const`
`320`	`320`	`{`
`321`	`321`	`int count = 0;`
	`322`	`+ auto ParentWidget = parentWidget();`
`322`	`323`	`for (auto i = 0; i < tabCount(); i++)`
`323`	`324`	`{`
`324`		`- if (tabAt(i)->isVisibleTo(parentWidget()))`
	`325`	`+ if (tabAt(i)->isVisibleTo(ParentWidget))`
`325`	`326`	`{`
`326`	`327`	`count++;`
`327`	`328`	`}`
`@@ -334,9 +335,10 @@ int CAutoHideSideBar::visibleTabCount() const`
`334`	`335`	`//============================================================================`
`335`	`336`	`bool CAutoHideSideBar::hasVisibleTabs() const`
`336`	`337`	`{`
	`338`	`+ auto ParentWidget = parentWidget();`
`337`	`339`	`for (auto i = 0; i < tabCount(); i++)`
`338`	`340`	`{`
`339`		`- if (tabAt(i)->isVisibleTo(parentWidget()))`
	`341`	`+ if (tabAt(i)->isVisibleTo(ParentWidget))`
`340`	`342`	`{`
`341`	`343`	`return true;`
`342`	`344`	`}`