Fixed issue #173 - tab changes position when redocking it to the same position

githubuser0xFFFF · githubuser0xFFFF · commit 516465aefb35 · 2020-05-15T12:25:22.000+02:00
diff --git a/src/DockContainerWidget.cpp b/src/DockContainerWidget.cpp
@@ -575,6 +575,11 @@ void DockContainerWidgetPrivate::moveIntoCenterOfSection(QWidget* Widget, CDockA
 	if (DroppedDockWidget)
 	{
 		CDockAreaWidget* OldDockArea = DroppedDockWidget->dockAreaWidget();
+		if (OldDockArea == TargetArea)
+		{
+			return;
+		}
+
 		if (OldDockArea)
 		{
 			OldDockArea->removeDockWidget(DroppedDockWidget);

Original file line number	Diff line number	Diff line change
`@@ -575,6 +575,11 @@ void DockContainerWidgetPrivate::moveIntoCenterOfSection(QWidget* Widget, CDockA`
`575`	`575`	`if (DroppedDockWidget)`
`576`	`576`	`{`
`577`	`577`	`CDockAreaWidget* OldDockArea = DroppedDockWidget->dockAreaWidget();`
	`578`	`+ if (OldDockArea == TargetArea)`
	`579`	`+ {`
	`580`	`+ return;`
	`581`	`+ }`
	`582`	`+`
`578`	`583`	`if (OldDockArea)`
`579`	`584`	`{`
`580`	`585`	`OldDockArea->removeDockWidget(DroppedDockWidget);`