Merge pull request #4086 from github/robertbrignull/error-unknown

Avoid specifying error type since the default is unknown

Author: robertbrignull

extensions/ql-vscode/scripts/source-map.ts

@@ -131,7 +131,7 @@ async function extractSourceMap() {
               resolve(sourceMapsDirectory, `${basename(file)}.map`),
             );
             rawSourceMaps.set(file, rawSourceMap);
-          } catch (e: unknown) {
+          } catch (e) {
             // If the file is not found, we will not decode it and not try reading this source map again
             if (e instanceof Error && "code" in e && e.code === "ENOENT") {
               rawSourceMaps.set(file, null);

extensions/ql-vscode/scripts/update-node-version.ts

@@ -93,7 +93,7 @@ async function updateNodeVersion() {
 
       // If it exists, we can break out of this loop
       break;
-    } catch (e: unknown) {
+    } catch (e) {
       if (!isExecError(e)) {
         throw e;
       }

extensions/ql-vscode/src/codeql-cli/distribution.ts

@@ -336,7 +336,7 @@ class ExtensionSpecificDistributionManager {
     const distributionStatePath = this.getDistributionStatePath();
     try {
       this.distributionState = await readJson(distributionStatePath);
-    } catch (e: unknown) {
+    } catch (e) {
       if (isIOError(e) && e.code === "ENOENT") {
         // If the file doesn't exist, that just means we need to create it
 

extensions/ql-vscode/src/common/short-paths.ts

@@ -45,7 +45,7 @@ export async function expandShortPaths(
 
   try {
     return await expandShortPathNative(absoluteShortPath, logger);
-  } catch (e: unknown) {
+  } catch (e) {
     void logger.log(
       `Failed to expand short path using native method: ${getErrorMessage(e)}`,
     );

extensions/ql-vscode/src/databases/local-databases-ui.ts

@@ -505,7 +505,7 @@ export class DatabaseUI extends DisposableObject {
   ): Promise<void> {
     try {
       await this.chooseAndSetDatabase(false, progress);
-    } catch (e: unknown) {
+    } catch (e) {
       void showAndLogExceptionWithTelemetry(
         this.app.logger,
         this.app.telemetry,

extensions/ql-vscode/src/databases/local-databases/database-manager.ts

@@ -411,7 +411,7 @@ export class DatabaseManager extends DisposableObject {
         qlpackStoragePath,
       );
       await qlPackGenerator.generate();
-    } catch (e: unknown) {
+    } catch (e) {
       void this.logger.log(
         `Could not create skeleton QL pack: ${getErrorMessage(e)}`,
       );

extensions/ql-vscode/src/databases/ui/db-panel.ts

@@ -432,7 +432,7 @@ export class DbPanel extends DisposableObject {
     try {
       // This will also validate that the controller repository is valid
       await getControllerRepo(this.app.credentials);
-    } catch (e: unknown) {
+    } catch (e) {
       if (e instanceof UserCancellationException) {
         return;
       }

extensions/ql-vscode/src/extension.ts

@@ -667,7 +667,7 @@ async function installOrUpdateThenTryActivate(
 
   try {
     await prepareCodeTour(app.commands);
-  } catch (e: unknown) {
+  } catch (e) {
     void extLogger.log(
       `Could not open tutorial workspace automatically: ${getErrorMessage(e)}`,
     );

extensions/ql-vscode/src/local-queries/skeleton-query-wizard.ts

@@ -132,7 +132,7 @@ export class SkeletonQueryWizard {
     // open the query file
     try {
       await this.openExampleFile();
-    } catch (e: unknown) {
+    } catch (e) {
       void this.app.logger.log(
         `Could not open example query file: ${getErrorMessage(e)}`,
       );
@@ -279,7 +279,7 @@ export class SkeletonQueryWizard {
       const qlPackGenerator = this.createQlPackGenerator();
 
       await qlPackGenerator.generate();
-    } catch (e: unknown) {
+    } catch (e) {
       void this.app.logger.log(
         `Could not create skeleton QL pack: ${getErrorMessage(e)}`,
       );
@@ -299,7 +299,7 @@ export class SkeletonQueryWizard {
 
       this.fileName = await this.determineNextFileName();
       await qlPackGenerator.createExampleQlFile(this.fileName);
-    } catch (e: unknown) {
+    } catch (e) {
       void this.app.logger.log(
         `Could not create query example file: ${getErrorMessage(e)}`,
       );
@@ -342,7 +342,7 @@ export class SkeletonQueryWizard {
       void withProgress(async (progress) => {
         try {
           await this.downloadDatabase(progress);
-        } catch (e: unknown) {
+        } catch (e) {
           if (e instanceof UserCancellationException) {
             return;
           }

extensions/ql-vscode/src/log-insights/summary-language-support.ts

@@ -113,7 +113,7 @@ export class SummaryLanguageSupport extends DisposableObject {
         const sourceMapText = await readFile(mapPath, "utf-8");
         const rawMap: RawSourceMap = JSON.parse(sourceMapText);
         this.sourceMap = await new SourceMapConsumer(rawMap);
-      } catch (e: unknown) {
+      } catch (e) {
         // Error reading sourcemap. Pretend there was no sourcemap.
         void extLogger.log(
           `Error reading sourcemap file '${mapPath}': ${getErrorMessage(e)}`,