From 733e7ea83a67d47ba1816ec4e9606bb8447990ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20August=C3=BDn?= Date: Fri, 4 Jul 2025 12:04:11 +0200 Subject: [PATCH 1/2] docs: VSCode examples fixed --- README.md | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/README.md b/README.md index 68742752..7b9e149f 100644 --- a/README.md +++ b/README.md @@ -161,8 +161,6 @@ Add the following JSON block to your IDE MCP settings. "run", "-i", "--rm", - "-e", - "GITHUB_PERSONAL_ACCESS_TOKEN", "ghcr.io/github/github-mcp-server" ], "env": { @@ -194,8 +192,6 @@ Optionally, you can add a similar example (i.e. without the mcp key) to a file c "run", "-i", "--rm", - "-e", - "GITHUB_PERSONAL_ACCESS_TOKEN", "ghcr.io/github/github-mcp-server" ], "env": { @@ -220,8 +216,6 @@ More about using MCP server tools in VS Code's [agent mode documentation](https: "run", "-i", "--rm", - "-e", - "GITHUB_PERSONAL_ACCESS_TOKEN", "ghcr.io/github/github-mcp-server" ], "env": { @@ -377,10 +371,6 @@ the hostname for GitHub Enterprise Server or GitHub Enterprise Cloud with data r "run", "-i", "--rm", - "-e", - "GITHUB_PERSONAL_ACCESS_TOKEN", - "-e", - "GITHUB_HOST", "ghcr.io/github/github-mcp-server" ], "env": { From 663d8f090ca254111ebe64e20fa6ef550fb88b1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20August=C3=BDn?= Date: Fri, 4 Jul 2025 15:20:53 +0200 Subject: [PATCH 2/2] fix: env is not relevant for Docker command --- README.md | 26 +++++++++----------------- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 7b9e149f..26237ce6 100644 --- a/README.md +++ b/README.md @@ -161,11 +161,9 @@ Add the following JSON block to your IDE MCP settings. "run", "-i", "--rm", + "-e", "GITHUB_PERSONAL_ACCESS_TOKEN=${input:github_token}", "ghcr.io/github/github-mcp-server" - ], - "env": { - "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token}" - } + ] } } } @@ -192,11 +190,9 @@ Optionally, you can add a similar example (i.e. without the mcp key) to a file c "run", "-i", "--rm", + "-e", "GITHUB_PERSONAL_ACCESS_TOKEN=${input:github_token}", "ghcr.io/github/github-mcp-server" - ], - "env": { - "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token}" - } + ] } } } @@ -216,11 +212,9 @@ More about using MCP server tools in VS Code's [agent mode documentation](https: "run", "-i", "--rm", + "-e", "GITHUB_PERSONAL_ACCESS_TOKEN=${input:github_token}", "ghcr.io/github/github-mcp-server" - ], - "env": { - "GITHUB_PERSONAL_ACCESS_TOKEN": "" - } + ] } } } @@ -371,12 +365,10 @@ the hostname for GitHub Enterprise Server or GitHub Enterprise Cloud with data r "run", "-i", "--rm", + "-e", "GITHUB_PERSONAL_ACCESS_TOKEN=${input:github_token}", + "-e", "GITHUB_HOST=https://", "ghcr.io/github/github-mcp-server" - ], - "env": { - "GITHUB_PERSONAL_ACCESS_TOKEN": "${input:github_token}", - "GITHUB_HOST": "https://" - } + ] } ```