Skip to content

Commit 37d1ed6

Browse files
LuluBeatsonSamMorrowDrums
authored andcommitted
return MinimalUser
1 parent 6c0453a commit 37d1ed6

File tree

2 files changed

+16
-11
lines changed

2 files changed

+16
-11
lines changed

pkg/github/context_tools.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,19 @@ func GetMe(getClient GetClientFn, t translations.TranslationHelperFunc) (mcp.Too
3838
), nil
3939
}
4040

41-
// Set nil to omit from output
42-
user.SiteAdmin = nil
41+
// Create minimal user representation instead of returning full user object
42+
minimalUser := MinimalUser{
43+
Login: user.GetLogin(),
44+
ID: user.GetID(),
45+
}
46+
if user.HTMLURL != nil {
47+
minimalUser.ProfileURL = *user.HTMLURL
48+
}
49+
if user.AvatarURL != nil {
50+
minimalUser.AvatarURL = *user.AvatarURL
51+
}
4352

44-
return MarshalledTextResult(user), nil
53+
return MarshalledTextResult(minimalUser), nil
4554
})
4655

4756
return tool, handler

pkg/github/context_tools_test.go

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -117,17 +117,13 @@ func Test_GetMe(t *testing.T) {
117117
}
118118

119119
// Unmarshal and verify the result
120-
var returnedUser github.User
120+
var returnedUser MinimalUser
121121
err = json.Unmarshal([]byte(textContent.Text), &returnedUser)
122122
require.NoError(t, err)
123123

124-
// Verify user details
125-
assert.Equal(t, *tc.expectedUser.Login, *returnedUser.Login)
126-
assert.Equal(t, *tc.expectedUser.Name, *returnedUser.Name)
127-
assert.Equal(t, *tc.expectedUser.Email, *returnedUser.Email)
128-
assert.Equal(t, *tc.expectedUser.Bio, *returnedUser.Bio)
129-
assert.Equal(t, *tc.expectedUser.HTMLURL, *returnedUser.HTMLURL)
130-
assert.Equal(t, *tc.expectedUser.Type, *returnedUser.Type)
124+
// Verify minimal user details
125+
assert.Equal(t, *tc.expectedUser.Login, returnedUser.Login)
126+
assert.Equal(t, *tc.expectedUser.HTMLURL, returnedUser.ProfileURL)
131127
})
132128
}
133129
}

0 commit comments

Comments
 (0)