speed up resolving fields

erik-krogh · erik-krogh · commit fcdba7ce5755 · 2022-08-11T12:31:53.000+02:00
diff --git a/ql/ql/src/codeql_ql/ast/internal/Variable.qll b/ql/ql/src/codeql_ql/ast/internal/Variable.qll
@@ -73,7 +73,12 @@ private module Cached {
 
   cached
   predicate resolveField(Identifier i, VarDef decl) {
-    scopeOf(i).containsField(decl, pragma[only_bind_into](getName(i)))
+    resolveFieldHelper(scopeOf(i), decl, getName(i))
+  }
+
+  pragma[noinline]
+  private predicate resolveFieldHelper(VariableScope scope, VarDef decl, string name) {
+    scope.containsField(decl, name)
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,12 @@ private module Cached {`
`73`	`73`
`74`	`74`	`cached`
`75`	`75`	`predicate resolveField(Identifier i, VarDef decl) {`
`76`		`- scopeOf(i).containsField(decl, pragma[only_bind_into](getName(i)))`
	`76`	`+ resolveFieldHelper(scopeOf(i), decl, getName(i))`
	`77`	`+ }`
	`78`	`+`
	`79`	`+ pragma[noinline]`
	`80`	`+ private predicate resolveFieldHelper(VariableScope scope, VarDef decl, string name) {`
	`81`	`+ scope.containsField(decl, name)`
`77`	`82`	`}`
`78`	`83`	`}`
`79`	`84`