Skip to content

Commit f1e6271

Browse files
RasmusWLyoff
andauthored
Python: Apply suggestions from code review
Co-authored-by: yoff <lerchedahl@gmail.com>
1 parent 461e2f3 commit f1e6271

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

python/ql/lib/semmle/python/frameworks/Django.qll

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ module PrivateDjango {
638638

639639
/**
640640
* A method call on a query-set or manager that returns a collection
641-
* containing instances of a django models.
641+
* containing instances of a django model.
642642
*/
643643
class QuerySetMethodInstanceCollection extends DataFlow::CallCfgNode {
644644
API::Node modelClass;
@@ -674,7 +674,9 @@ module PrivateDjango {
674674
//
675675
// but for now, we just model a store step directly from the synthetic
676676
// node to the method call.
677-
// extra method on query-set/manager that does _not_ return a query-set
677+
//
678+
// extra method on query-set/manager that does _not_ return a query-set,
679+
// but a collection of instances.
678680
modelClass = subclassRef() and
679681
methodName in ["iterator", "bulk_create"] and
680682
this = [manager(modelClass), querySet(modelClass)].getMember(methodName).getACall()

0 commit comments

Comments
 (0)