Python: Apply suggestions from code review

RasmusWL · yoff · web-flow · commit f1b0a814e057 · 2022-06-17T15:04:57.000+02:00
Co-authored-by: yoff &lt;lerchedahl@gmail.com&gt;
diff --git a/python/ql/lib/semmle/python/ApiGraphs.qll b/python/ql/lib/semmle/python/ApiGraphs.qll
@@ -597,11 +597,9 @@ module API {
           // "benign" and let subclasses edges flow through anyway.
           // see example in https://github.com/django/django/blob/c2250cfb80e27cdf8d098428824da2800a18cadf/tests/auth_tests/test_views.py#L40-L46
           (
-            not exists(clsExpr.getADecorator()) and
             ref.asExpr() = clsExpr
             or
-            ref.asExpr() = clsExpr.getADecoratorCall() and
-            not exists(PY::Call otherDecorator | otherDecorator.getArg(0) = ref.asExpr())
+            ref.asExpr() = clsExpr.getADecoratorCall()
           )
         )
         or

Original file line number	Diff line number	Diff line change
`@@ -597,11 +597,9 @@ module API {`
`597`	`597`	`// "benign" and let subclasses edges flow through anyway.`
`598`	`598`	`// see example in https://github.com/django/django/blob/c2250cfb80e27cdf8d098428824da2800a18cadf/tests/auth_tests/test_views.py#L40-L46`
`599`	`599`	`(`
`600`		`- not exists(clsExpr.getADecorator()) and`
`601`	`600`	`ref.asExpr() = clsExpr`
`602`	`601`	`or`
`603`		`- ref.asExpr() = clsExpr.getADecoratorCall() and`
`604`		`- not exists(PY::Call otherDecorator \| otherDecorator.getArg(0) = ref.asExpr())`
	`602`	`+ ref.asExpr() = clsExpr.getADecoratorCall()`
`605`	`603`	`)`
`606`	`604`	`)`
`607`	`605`	`or`