Merge pull request #7662 from JLLeitschuh/patch-2

aschackmull · web-flow · commit f1545301410b · 2022-01-20T11:13:59.000+01:00
Fix typo in FileWritable
diff --git a/java/ql/lib/semmle/code/java/security/FileWritable.qll b/java/ql/lib/semmle/code/java/security/FileWritable.qll
@@ -62,7 +62,7 @@ private EnumConstant getAContainedEnumConstant(Expr enumSetRef) {
 private VarAccess getFileForPathConversion(Expr pathExpr) {
   pathExpr.getType().(RefType).hasQualifiedName("java.nio.file", "Path") and
   (
-    // Look for conversion from `File` to `Path` using `file.getPath()`.
+    // Look for conversion from `File` to `Path` using `file.toPath()`.
     exists(MethodAccess fileToPath |
       fileToPath = pathExpr and
       result = fileToPath.getQualifier() and

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ private EnumConstant getAContainedEnumConstant(Expr enumSetRef) {`
`62`	`62`	`private VarAccess getFileForPathConversion(Expr pathExpr) {`
`63`	`63`	`pathExpr.getType().(RefType).hasQualifiedName("java.nio.file", "Path") and`
`64`	`64`	`(`
`65`		- // Look for conversion from `File` to `Path` using `file.getPath()`.
	`65`	+ // Look for conversion from `File` to `Path` using `file.toPath()`.
`66`	`66`	`exists(MethodAccess fileToPath \|`
`67`	`67`	`fileToPath = pathExpr and`
`68`	`68`	`result = fileToPath.getQualifier() and`