Swift: remove getMethodDeclaration

redsun82 · redsun82 · commit f0ec43b04c6b · 2022-08-19T15:37:49.000+02:00
`getStaticTarget` gives the same result.
diff --git a/swift/ql/lib/codeql/swift/elements/expr/ApplyExpr.qll b/swift/ql/lib/codeql/swift/elements/expr/ApplyExpr.qll
@@ -11,8 +11,6 @@ class ApplyExpr extends ApplyExprBase {
       (
         result = f.(DeclRefExpr).getDecl()
         or
-        result = f.(MethodRefExpr).getMethod()
-        or
         result = f.(ConstructorRefCallExpr).getFunction().(DeclRefExpr).getDecl()
       )
     )
@@ -34,7 +32,7 @@ class MethodApplyExpr extends ApplyExpr {
 
   MethodApplyExpr() { method = this.getFunction() }
 
-  AbstractFunctionDecl getMethodDeclaration() { result = method.getMethod() }
+  override AbstractFunctionDecl getStaticTarget() { result = method.getMethod() }
 
   override Expr getQualifier() { result = method.getBase() }
 }

Original file line number	Diff line number	Diff line change
`@@ -11,8 +11,6 @@ class ApplyExpr extends ApplyExprBase {`
`11`	`11`	`(`
`12`	`12`	`result = f.(DeclRefExpr).getDecl()`
`13`	`13`	`or`
`14`		`- result = f.(MethodRefExpr).getMethod()`
`15`		`- or`
`16`	`14`	`result = f.(ConstructorRefCallExpr).getFunction().(DeclRefExpr).getDecl()`
`17`	`15`	`)`
`18`	`16`	`)`
`@@ -34,7 +32,7 @@ class MethodApplyExpr extends ApplyExpr {`
`34`	`32`
`35`	`33`	`MethodApplyExpr() { method = this.getFunction() }`
`36`	`34`
`37`		`- AbstractFunctionDecl getMethodDeclaration() { result = method.getMethod() }`
	`35`	`+ override AbstractFunctionDecl getStaticTarget() { result = method.getMethod() }`
`38`	`36`
`39`	`37`	`override Expr getQualifier() { result = method.getBase() }`
`40`	`38`	`}`