rename isBeforeCode to isCommentAfterCode

erik-krogh · erik-krogh · commit ed7e1206ff2d · 2022-04-01T12:55:00.000+02:00
diff --git a/python/ql/lib/semmle/python/filters/GeneratedCode.qll b/python/ql/lib/semmle/python/filters/GeneratedCode.qll
@@ -41,7 +41,7 @@ private int minStmtLine(File file) {
 }
 
 pragma[nomagic]
-private predicate isBeforeCode(Comment c, File f) {
+private predicate isCommentAfterCode(Comment c, File f) {
   f = c.getLocation().getFile() and
   minStmtLine(f) < c.getLocation().getStartLine()
 }
@@ -51,7 +51,7 @@ private string comment_or_docstring(File f, boolean before_code) {
     c.getLocation().getFile() = f and
     result = c.getText()
   |
-    if isBeforeCode(c, f) then before_code = false else before_code = true
+    if isCommentAfterCode(c, f) then before_code = false else before_code = true
   )
   or
   exists(Module m | m.getFile() = f |

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ private int minStmtLine(File file) {`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`pragma[nomagic]`
`44`		`-private predicate isBeforeCode(Comment c, File f) {`
	`44`	`+private predicate isCommentAfterCode(Comment c, File f) {`
`45`	`45`	`f = c.getLocation().getFile() and`
`46`	`46`	`minStmtLine(f) < c.getLocation().getStartLine()`
`47`	`47`	`}`
`@@ -51,7 +51,7 @@ private string comment_or_docstring(File f, boolean before_code) {`
`51`	`51`	`c.getLocation().getFile() = f and`
`52`	`52`	`result = c.getText()`
`53`	`53`	`\|`
`54`		`- if isBeforeCode(c, f) then before_code = false else before_code = true`
	`54`	`+ if isCommentAfterCode(c, f) then before_code = false else before_code = true`
`55`	`55`	`)`
`56`	`56`	`or`
`57`	`57`	`exists(Module m \| m.getFile() = f \|`