Remove type check from the barrier predicate

joefarebrother · joefarebrother · commit eb3655da1c09 · 2022-09-21T13:57:32.000+01:00
diff --git a/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll b/java/ql/lib/semmle/code/java/security/WebviewDubuggingEnabledQuery.qll
@@ -34,8 +34,6 @@ class WebviewDebugEnabledConfig extends DataFlow::Configuration {
   }
 
   override predicate isBarrier(DataFlow::Node node) {
-    not node.getType() instanceof BooleanType
-    or
     exists(Guard debug | isDebugCheck(debug) and debug.controls(node.asExpr().getBasicBlock(), _))
     or
     node.getEnclosingCallable().getDeclaringType() instanceof NonSecurityTestClass

Original file line number	Diff line number	Diff line change
`@@ -34,8 +34,6 @@ class WebviewDebugEnabledConfig extends DataFlow::Configuration {`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`override predicate isBarrier(DataFlow::Node node) {`
`37`		`- not node.getType() instanceof BooleanType`
`38`		`- or`
`39`	`37`	`exists(Guard debug \| isDebugCheck(debug) and debug.controls(node.asExpr().getBasicBlock(), _))`
`40`	`38`	`or`
`41`	`39`	`node.getEnclosingCallable().getDeclaringType() instanceof NonSecurityTestClass`