Skip to content

Commit eb1b3f8

Browse files
authored
Merge pull request #9689 from igfoo/igfoo/makeprivate
Kotlin: Make some more methods private
2 parents 71efffd + bd8a8d0 commit eb1b3f8

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

java/kotlin-extractor/src/main/kotlin/KotlinFileExtractor.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ open class KotlinFileExtractor(
4141
globalExtensionState: KotlinExtractorGlobalState
4242
): KotlinUsesExtractor(logger, tw, dependencyCollector, externalClassExtractor, primitiveTypeMapping, pluginContext, globalExtensionState) {
4343

44-
inline fun <T> with(kind: String, element: IrElement, f: () -> T): T {
44+
private inline fun <T> with(kind: String, element: IrElement, f: () -> T): T {
4545
val name = when (element) {
4646
is IrFile -> element.name
4747
is IrDeclarationWithName -> element.name.asString()
@@ -2192,7 +2192,7 @@ open class KotlinFileExtractor(
21922192
}
21932193
}
21942194

2195-
fun getStatementOriginOperator(origin: IrStatementOrigin?) = when (origin) {
2195+
private fun getStatementOriginOperator(origin: IrStatementOrigin?) = when (origin) {
21962196
IrStatementOrigin.PLUSEQ -> "plus"
21972197
IrStatementOrigin.MINUSEQ -> "minus"
21982198
IrStatementOrigin.MULTEQ -> "times"

java/kotlin-extractor/src/main/kotlin/KotlinUsesExtractor.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ open class KotlinUsesExtractor(
190190
}
191191

192192
// The Kotlin compiler internal representation of Outer<A, B>.Inner<C, D>.InnerInner<E, F>.someFunction<G, H>.LocalClass<I, J> is LocalClass<I, J, G, H, E, F, C, D, A, B>. This function returns [A, B, C, D, E, F, G, H, I, J].
193-
fun orderTypeArgsLeftToRight(c: IrClass, argsIncludingOuterClasses: List<IrTypeArgument>?): List<IrTypeArgument>? {
193+
private fun orderTypeArgsLeftToRight(c: IrClass, argsIncludingOuterClasses: List<IrTypeArgument>?): List<IrTypeArgument>? {
194194
if(argsIncludingOuterClasses.isNullOrEmpty())
195195
return argsIncludingOuterClasses
196196
val ret = ArrayList<IrTypeArgument>()
@@ -237,7 +237,7 @@ open class KotlinUsesExtractor(
237237
return UseClassInstanceResult(classTypeResult, extractClass)
238238
}
239239

240-
fun isArray(t: IrSimpleType) = t.isBoxedArray || t.isPrimitiveArray()
240+
private fun isArray(t: IrSimpleType) = t.isBoxedArray || t.isPrimitiveArray()
241241

242242
fun extractClassLaterIfExternal(c: IrClass) {
243243
if (isExternalDeclaration(c)) {
@@ -1464,7 +1464,7 @@ open class KotlinUsesExtractor(
14641464
return t
14651465
}
14661466

1467-
fun eraseTypeParameter(t: IrTypeParameter) =
1467+
private fun eraseTypeParameter(t: IrTypeParameter) =
14681468
erase(t.superTypes[0])
14691469

14701470
/**

java/kotlin-extractor/src/main/kotlin/utils/AutoCloseableUse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ fun AutoCloseable?.closeFinallyAC(cause: Throwable?) = when {
4040
} catch (closeException: Throwable) {
4141
cause.addSuppressed(closeException)
4242
}
43-
}
43+
}

java/kotlin-extractor/src/main/kotlin/utils/Logger.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ open class Logger(val loggerBase: LoggerBase, open val tw: TrapWriter) {
226226
loggerBase.info(tw, msg)
227227
}
228228

229-
fun warn(msg: String, extraInfo: String?) {
229+
private fun warn(msg: String, extraInfo: String?) {
230230
loggerBase.warn(tw, msg, extraInfo)
231231
}
232232
fun warn(msg: String, exn: Throwable) {
@@ -236,7 +236,7 @@ open class Logger(val loggerBase: LoggerBase, open val tw: TrapWriter) {
236236
warn(msg, null)
237237
}
238238

239-
fun error(msg: String, extraInfo: String?) {
239+
private fun error(msg: String, extraInfo: String?) {
240240
loggerBase.error(tw, msg, extraInfo)
241241
}
242242
fun error(msg: String) {

0 commit comments

Comments
 (0)