Skip to content

Commit ea9a5b7

Browse files
author
Dave Bartolomeo
committed
Don't bother hiding toString() and getLocation()
1 parent 7272587 commit ea9a5b7

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

cpp/ql/lib/experimental/semmle/code/cpp/semantic/SemanticExpr.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ private import SemanticExprSpecific::SemanticExprConfig as Specific
1212
* the expression's opcode (`getOpcode()`).
1313
*/
1414
class SemExpr instanceof Specific::Expr {
15-
final string toString() { result = Specific::exprToString(this) }
15+
final string toString() { result = super.toString() }
1616

17-
final Specific::Location getLocation() { result = Specific::getExprLocation(this) }
17+
final Specific::Location getLocation() { result = super.getLocation() }
1818

1919
Opcode getOpcode() { result instanceof Opcode::Unknown }
2020

cpp/ql/lib/experimental/semmle/code/cpp/semantic/SemanticExprSpecific.qll

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -13,10 +13,6 @@ module SemanticExprConfig {
1313

1414
class Expr = IR::Instruction;
1515

16-
string exprToString(Expr e) { result = e.toString() }
17-
18-
Location getExprLocation(Expr e) { result = e.getLocation() }
19-
2016
SemBasicBlock getExprBasicBlock(Expr e) { result = getSemanticBasicBlock(e.getBlock()) }
2117

2218
private predicate anyConstantExpr(Expr expr, SemType type, string value) {

0 commit comments

Comments
 (0)