Skip to content

Commit e4b762b

Browse files
Improve qldoc; make taint tracking
1 parent b924de6 commit e4b762b

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

java/ql/lib/semmle/code/java/security/SensitiveLoggingQuery.qll

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import semmle.code.java.dataflow.TaintTracking
66
import semmle.code.java.security.SensitiveActions
77
import DataFlow
88

9-
/** Variable keeps sensitive information judging by its name * */
9+
/** A variable that may hold sensitive information, judging by its name. * */
1010
class CredentialExpr extends Expr {
1111
CredentialExpr() {
1212
exists(Variable v | this = v.getAnAccess() |
@@ -16,14 +16,11 @@ class CredentialExpr extends Expr {
1616
}
1717
}
1818

19-
class SensitiveLoggerConfiguration extends DataFlow::Configuration {
19+
/* A data-flow configuration for identifying potentially-sensitive data flowing to a log output. */
20+
class SensitiveLoggerConfiguration extends TaintTracking::Configuration {
2021
SensitiveLoggerConfiguration() { this = "SensitiveLoggerConfiguration" }
2122

2223
override predicate isSource(DataFlow::Node source) { source.asExpr() instanceof CredentialExpr }
2324

2425
override predicate isSink(DataFlow::Node sink) { sinkNode(sink, "logging") }
25-
26-
override predicate isAdditionalFlowStep(DataFlow::Node node1, DataFlow::Node node2) {
27-
TaintTracking::localTaintStep(node1, node2)
28-
}
2926
}

0 commit comments

Comments
 (0)