File tree Expand file tree Collapse file tree 2 files changed +5
-2
lines changed Expand file tree Collapse file tree 2 files changed +5
-2
lines changed Original file line number Diff line number Diff line change @@ -74,7 +74,7 @@ class AndroidApplicationXmlElement extends XmlElement {
74
74
predicate requiresPermissions ( ) { this .getAnAttribute ( ) .( AndroidPermissionXmlAttribute ) .isFull ( ) }
75
75
76
76
/**
77
- * Holds if this application element enables the `android:allowBackup` attribute.
77
+ * Holds if this application element does not disable the `android:allowBackup` attribute.
78
78
*
79
79
* https://developer.android.com/guide/topics/data/autobackup
80
80
*/
Original file line number Diff line number Diff line change 1
1
/**
2
2
* @name Android allowBackup attribute enabled
3
- * @description
3
+ * @description Android manifests which do not disable the `android:allowBackup` attribute allow backups, which can store sensitive information.
4
4
* @kind problem
5
5
* @problem.severity recommendation
6
6
* @security-severity 7.5
@@ -17,8 +17,11 @@ from AndroidApplicationXmlElement androidAppElem
17
17
where
18
18
not androidAppElem .getFile ( ) .( AndroidManifestXmlFile ) .isInBuildDirectory ( ) and
19
19
(
20
+ // explicitly sets android:allowBackup=true
20
21
androidAppElem .allowsBackupExplicitly ( )
21
22
or
23
+ // Manifest providing the main intent for an application, and does not explicitly
24
+ // disallow the allowBackup attribute
22
25
androidAppElem .providesMainIntent ( ) and
23
26
androidAppElem .allowsBackup ( )
24
27
)
You can’t perform that action at this time.
0 commit comments