Add models for go 1.19's new atomic pointer typex

Author: smowton

go/ql/lib/semmle/go/frameworks/stdlib/SyncAtomic.qll

@@ -69,13 +69,15 @@ module SyncAtomic {
     FunctionOutput outp;
 
     MethodModels() {
-      // signature: func (*Value) Load() (x interface{})
-      hasQualifiedName("sync/atomic", "Value", "Load") and
-      (inp.isReceiver() and outp.isResult())
-      or
-      // signature: func (*Value) Store(x interface{})
-      hasQualifiedName("sync/atomic", "Value", "Store") and
-      (inp.isParameter(0) and outp.isReceiver())
+      exists(string containerType | containerType = ["Value", "Pointer", "Uintptr"] |
+        // signature: func (*Containertype) Load/Swap() (x containedtype)
+        hasQualifiedName("sync/atomic", containerType, ["Load", "Swap"]) and
+        (inp.isReceiver() and outp.isResult())
+        or
+        // signature: func (*Containertype) Store/Swap(x containedtype) [(x containedtype)]
+        hasQualifiedName("sync/atomic", containerType, ["Store", "Swap"]) and
+        (inp.isParameter(0) and outp.isReceiver())
+      )
     }
 
     override predicate hasTaintFlow(FunctionInput input, FunctionOutput output) {

go/ql/test/library-tests/semmle/go/frameworks/StdlibTaintFlow/SyncAtomic.go

@@ -1,4 +1,5 @@
-// Code generated by https://github.com/gagliardetto/codebox. DO NOT EDIT.
+// Code partially generated by https://github.com/gagliardetto/codebox, with manual additions
+// for atomic.Pointer and Uintptr, as well as atomic.Value's Swap method.
 
 package main
 
@@ -99,6 +100,73 @@ func TaintStepTest_SyncAtomicValueStore_B0I0O0(sourceCQL interface{}) interface{
 	return intoValue631
 }
 
+func TaintStepTest_SyncAtomicValueSwap(sourceCQL interface{}) interface{} {
+	fromInterface598 := sourceCQL.(interface{})
+	var intoValue631 atomic.Value
+	intoValue631.Swap(fromInterface598)
+	return intoValue631
+}
+
+func TaintStepTest_SyncAtomicValueSwap2(sourceCQL interface{}) interface{} {
+	fromValue246 := sourceCQL.(atomic.Value)
+	intoInterface898 := fromValue246.Swap("clean")
+	return intoInterface898
+}
+
+func TaintStepTest_SyncAtomicPointerLoad_B0I0O0(sourceCQL interface{}) interface{} {
+	fromValue246 := sourceCQL.(atomic.Pointer[string])
+	intoInterface898 := fromValue246.Load()
+	return intoInterface898
+}
+
+func TaintStepTest_SyncAtomicPointerStore_B0I0O0(sourceCQL interface{}) interface{} {
+	fromInterface598 := sourceCQL.(*string)
+	var intoValue631 atomic.Pointer[string]
+	intoValue631.Store(fromInterface598)
+	return intoValue631
+}
+
+func TaintStepTest_SyncAtomicPointerSwap(sourceCQL interface{}) interface{} {
+	fromInterface598 := sourceCQL.(*string)
+	var intoValue631 atomic.Pointer[string]
+	intoValue631.Swap(fromInterface598)
+	return intoValue631
+}
+
+func TaintStepTest_SyncAtomicPointerSwap2(sourceCQL interface{}) interface{} {
+	fromValue246 := sourceCQL.(atomic.Pointer[string])
+	clean := "Clean"
+	intoInterface898 := fromValue246.Swap(&clean)
+	return intoInterface898
+}
+
+func TaintStepTest_SyncAtomicUintptrLoad_B0I0O0(sourceCQL interface{}) interface{} {
+	fromValue246 := sourceCQL.(atomic.Uintptr)
+	intoInterface898 := fromValue246.Load()
+	return intoInterface898
+}
+
+func TaintStepTest_SyncAtomicUintptrStore_B0I0O0(sourceCQL interface{}) interface{} {
+	fromInterface598 := sourceCQL.(uintptr)
+	var intoValue631 atomic.Uintptr
+	intoValue631.Store(fromInterface598)
+	return intoValue631
+}
+
+func TaintStepTest_SyncAtomicUintptrSwap(sourceCQL interface{}) interface{} {
+	fromInterface598 := sourceCQL.(uintptr)
+	var intoValue631 atomic.Uintptr
+	intoValue631.Swap(fromInterface598)
+	return intoValue631
+}
+
+func TaintStepTest_SyncAtomicUintptrSwap2(sourceCQL interface{}) interface{} {
+	fromValue246 := sourceCQL.(atomic.Uintptr)
+	clean := "Clean"
+	intoInterface898 := fromValue246.Swap(uintptr(unsafe.Pointer(&clean)))
+	return intoInterface898
+}
+
 func RunAllTaints_SyncAtomic() {
 	{
 		source := newSource(0)
@@ -170,4 +238,54 @@ func RunAllTaints_SyncAtomic() {
 		out := TaintStepTest_SyncAtomicValueStore_B0I0O0(source)
 		sink(13, out)
 	}
+	{
+		source := newSource(14)
+		out := TaintStepTest_SyncAtomicValueSwap(source)
+		sink(14, out)
+	}
+	{
+		source := newSource(15)
+		out := TaintStepTest_SyncAtomicValueSwap2(source)
+		sink(15, out)
+	}
+	{
+		source := newSource(16)
+		out := TaintStepTest_SyncAtomicPointerLoad_B0I0O0(source)
+		sink(16, out)
+	}
+	{
+		source := newSource(17)
+		out := TaintStepTest_SyncAtomicPointerStore_B0I0O0(source)
+		sink(17, out)
+	}
+	{
+		source := newSource(18)
+		out := TaintStepTest_SyncAtomicPointerSwap(source)
+		sink(18, out)
+	}
+	{
+		source := newSource(19)
+		out := TaintStepTest_SyncAtomicPointerSwap2(source)
+		sink(19, out)
+	}
+	{
+		source := newSource(20)
+		out := TaintStepTest_SyncAtomicUintptrLoad_B0I0O0(source)
+		sink(20, out)
+	}
+	{
+		source := newSource(21)
+		out := TaintStepTest_SyncAtomicUintptrStore_B0I0O0(source)
+		sink(21, out)
+	}
+	{
+		source := newSource(22)
+		out := TaintStepTest_SyncAtomicUintptrSwap(source)
+		sink(22, out)
+	}
+	{
+		source := newSource(23)
+		out := TaintStepTest_SyncAtomicUintptrSwap2(source)
+		sink(23, out)
+	}
 }