updated to getRelativePath with %build%

Author: Jami Cogswell

java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.ql

@@ -17,5 +17,5 @@ from AndroidXmlAttribute androidXmlAttr
 where
   androidXmlAttr.getName() = "debuggable" and
   androidXmlAttr.getValue() = "true" and
-  not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%/build%")
+  not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%build%")
 select androidXmlAttr, "The 'android:debuggable' attribute is enabled."

java/ql/test/query-tests/security/CWE-489/DebuggableAttributeEnabledTest.ql

@@ -12,7 +12,7 @@ class DebuggableAttributeTrueTest extends InlineExpectationsTest {
     exists(AndroidXmlAttribute androidXmlAttr |
       androidXmlAttr.getName() = "debuggable" and
       androidXmlAttr.getValue() = "true" and
-      not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%/build%")
+      not androidXmlAttr.getLocation().getFile().getRelativePath().matches("%build%")
     |
       androidXmlAttr.getLocation() = location and
       element = androidXmlAttr.toString() and

java/ql/test/query-tests/security/CWE-489/Test.java

@@ -1,39 +1,43 @@
-package com.example.myapp;
+public class Test {
 
-import android.app.Fragment;
-import android.os.Bundle;
-import android.view.LayoutInflater;
-import android.view.View;
-import android.view.ViewGroup;
-import android.widget.Button;
-import androidx.fragment.app.FragmentActivity;
-import androidx.fragment.app.FragmentTransaction;
+}
 
-public class Test extends FragmentActivity {
+// package com.example.myapp;
 
-    @Override
-    public void onCreate(Bundle savedInstance) {
-        try {
-            super.onCreate(savedInstance);
-            final String fname = getIntent().getStringExtra("fname");
-            FragmentTransaction ft = getSupportFragmentManager().beginTransaction();
-            Class<Fragment> fClass = (Class<Fragment>) Class.forName(fname);
-            ft.add(fClass.newInstance(), ""); // hasTaintFlow
-            ft.add(0, Fragment.instantiate(this, fname), null); // hasTaintFlow
-            ft.add(0, Fragment.instantiate(this, fname, null)); // hasTaintFlow
-            ft.add(0, fClass, null, ""); // hasTaintFlow
-            ft.add(0, fClass.newInstance(), ""); // hasTaintFlow
-            ft.attach(fClass.newInstance()); // hasTaintFlow
-            ft.replace(0, fClass, null); // hasTaintFlow
-            ft.replace(0, fClass.newInstance()); // hasTaintFlow
-            ft.replace(0, fClass, null, ""); // hasTaintFlow
-            ft.replace(0, fClass.newInstance(), ""); // hasTaintFlow
+// import android.app.Fragment;
+// import android.os.Bundle;
+// import android.view.LayoutInflater;
+// import android.view.View;
+// import android.view.ViewGroup;
+// import android.widget.Button;
+// import androidx.fragment.app.FragmentActivity;
+// import androidx.fragment.app.FragmentTransaction;
 
-            ft.add(Fragment.class.newInstance(), ""); // Safe
-            ft.attach(Fragment.class.newInstance()); // Safe
-            ft.replace(0, Fragment.class.newInstance(), ""); // Safe
-        } catch (Exception e) {
-        }
-    }
+// public class Test extends FragmentActivity {
 
-}
+//     @Override
+//     public void onCreate(Bundle savedInstance) {
+//         try {
+//             super.onCreate(savedInstance);
+//             final String fname = getIntent().getStringExtra("fname");
+//             FragmentTransaction ft = getSupportFragmentManager().beginTransaction();
+//             Class<Fragment> fClass = (Class<Fragment>) Class.forName(fname);
+//             ft.add(fClass.newInstance(), ""); // hasTaintFlow
+//             ft.add(0, Fragment.instantiate(this, fname), null); // hasTaintFlow
+//             ft.add(0, Fragment.instantiate(this, fname, null)); // hasTaintFlow
+//             ft.add(0, fClass, null, ""); // hasTaintFlow
+//             ft.add(0, fClass.newInstance(), ""); // hasTaintFlow
+//             ft.attach(fClass.newInstance()); // hasTaintFlow
+//             ft.replace(0, fClass, null); // hasTaintFlow
+//             ft.replace(0, fClass.newInstance()); // hasTaintFlow
+//             ft.replace(0, fClass, null, ""); // hasTaintFlow
+//             ft.replace(0, fClass.newInstance(), ""); // hasTaintFlow
+
+//             ft.add(Fragment.class.newInstance(), ""); // Safe
+//             ft.attach(Fragment.class.newInstance()); // Safe
+//             ft.replace(0, Fragment.class.newInstance(), ""); // Safe
+//         } catch (Exception e) {
+//         }
+//     }
+
+// }