Skip to content

Commit d094bbc

Browse files
jheliejhelie
authored
Merge pull request #8546 from github/jhelie/enforce-unknown-incompatibiliy-with-notasink
ML: add defensive check to ensure Unknown endpoints cannot also be NotASink
2 parents c3f1fba + 1e39a9c commit d094bbc

File tree

5 files changed

+191
-0
lines changed

5 files changed

+191
-0
lines changed

‎javascript/ql/experimental/adaptivethreatmodeling/modelbuilding/extraction/ExtractEndpointData.qll

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,11 @@ private DataFlow::Node getANotASink(NotASinkReason reason) {
7575
*/
7676
private DataFlow::Node getAnUnknown(Query query) {
7777
getAtmCfg(query).isEffectiveSink(result) and
78+
// Effective sinks should exclude sinks but this is a defensive requirement
7879
not result = getASink(query) and
80+
// Effective sinks should exclude NotASink but for some queries (e.g. Xss) this is currently not always the case and
81+
// so this is a defensive requirement
82+
not result = getANotASink(_) and
7983
// Only consider the source code for the project being analyzed.
8084
exists(result.getFile().getRelativePath())
8185
}

‎javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_unit_tests/ExtractEndpointData.expected

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,50 @@ endpoints
251251
| index.js:78:30:78:39 | "someData" | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
252252
| index.js:78:30:78:39 | "someData" | Xss | notASinkReason | LoggerMethod | string |
253253
| index.js:78:30:78:39 | "someData" | Xss | sinkLabel | NotASink | string |
254+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | hasFlowFromSource | false | boolean |
255+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isConstantExpression | false | boolean |
256+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
257+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | ClientRequest | string |
258+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | JQueryArgument | string |
259+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | sinkLabel | NotASink | string |
260+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | hasFlowFromSource | false | boolean |
261+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isConstantExpression | false | boolean |
262+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
263+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | ClientRequest | string |
264+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | JQueryArgument | string |
265+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | sinkLabel | NotASink | string |
266+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | hasFlowFromSource | false | boolean |
267+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isConstantExpression | false | boolean |
268+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
269+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | ClientRequest | string |
270+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | JQueryArgument | string |
271+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | sinkLabel | NotASink | string |
272+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | hasFlowFromSource | false | boolean |
273+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isConstantExpression | false | boolean |
274+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
275+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | ClientRequest | string |
276+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | JQueryArgument | string |
277+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | sinkLabel | NotASink | string |
278+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | hasFlowFromSource | false | boolean |
279+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isConstantExpression | false | boolean |
280+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
281+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | notASinkReason | ClientRequest | string |
282+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | sinkLabel | NotASink | string |
283+
| index.js:84:12:84:18 | foo.bar | SqlInjection | hasFlowFromSource | false | boolean |
284+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isConstantExpression | false | boolean |
285+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
286+
| index.js:84:12:84:18 | foo.bar | SqlInjection | notASinkReason | ClientRequest | string |
287+
| index.js:84:12:84:18 | foo.bar | SqlInjection | sinkLabel | NotASink | string |
288+
| index.js:84:12:84:18 | foo.bar | TaintedPath | hasFlowFromSource | false | boolean |
289+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isConstantExpression | false | boolean |
290+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
291+
| index.js:84:12:84:18 | foo.bar | TaintedPath | notASinkReason | ClientRequest | string |
292+
| index.js:84:12:84:18 | foo.bar | TaintedPath | sinkLabel | NotASink | string |
293+
| index.js:84:12:84:18 | foo.bar | Xss | hasFlowFromSource | false | boolean |
294+
| index.js:84:12:84:18 | foo.bar | Xss | isConstantExpression | false | boolean |
295+
| index.js:84:12:84:18 | foo.bar | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
296+
| index.js:84:12:84:18 | foo.bar | Xss | notASinkReason | ClientRequest | string |
297+
| index.js:84:12:84:18 | foo.bar | Xss | sinkLabel | NotASink | string |
254298
tokenFeatures
255299
| applications/examples/static/epydoc/epydoc.js:2:15:2:33 | "Should be ignored" | argumentIndex | 0 |
256300
| applications/examples/static/epydoc/epydoc.js:2:15:2:33 | "Should be ignored" | calleeAccessPath | |
@@ -412,3 +456,19 @@ tokenFeatures
412456
| index.js:78:30:78:39 | "someData" | enclosingFunctionBody | console log someData |
413457
| index.js:78:30:78:39 | "someData" | enclosingFunctionName | identity#functionalargument |
414458
| index.js:78:30:78:39 | "someData" | receiverName | console |
459+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | argumentIndex | 0 |
460+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPath | |
461+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPathWithStructuralInfo | |
462+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeApiName | |
463+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeName | ajax |
464+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionBody | foo $ ajax url foo bar |
465+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionName | effectiveSinkAndNotASink |
466+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | receiverName | $ |
467+
| index.js:84:12:84:18 | foo.bar | argumentIndex | |
468+
| index.js:84:12:84:18 | foo.bar | calleeAccessPath | |
469+
| index.js:84:12:84:18 | foo.bar | calleeAccessPathWithStructuralInfo | |
470+
| index.js:84:12:84:18 | foo.bar | calleeApiName | |
471+
| index.js:84:12:84:18 | foo.bar | calleeName | |
472+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionBody | foo $ ajax url foo bar |
473+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionName | effectiveSinkAndNotASink |
474+
| index.js:84:12:84:18 | foo.bar | receiverName | |

‎javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_unit_tests/ExtractEndpointDataEvaluation.expected

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,50 @@ endpoints
231231
| index.js:78:30:78:39 | "someData" | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
232232
| index.js:78:30:78:39 | "someData" | Xss | notASinkReason | LoggerMethod | string |
233233
| index.js:78:30:78:39 | "someData" | Xss | sinkLabel | NotASink | string |
234+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | hasFlowFromSource | false | boolean |
235+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isConstantExpression | false | boolean |
236+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
237+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | ClientRequest | string |
238+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | JQueryArgument | string |
239+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | sinkLabel | NotASink | string |
240+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | hasFlowFromSource | false | boolean |
241+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isConstantExpression | false | boolean |
242+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
243+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | ClientRequest | string |
244+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | JQueryArgument | string |
245+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | sinkLabel | NotASink | string |
246+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | hasFlowFromSource | false | boolean |
247+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isConstantExpression | false | boolean |
248+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
249+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | ClientRequest | string |
250+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | JQueryArgument | string |
251+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | sinkLabel | NotASink | string |
252+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | hasFlowFromSource | false | boolean |
253+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isConstantExpression | false | boolean |
254+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
255+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | ClientRequest | string |
256+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | JQueryArgument | string |
257+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | sinkLabel | NotASink | string |
258+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | hasFlowFromSource | false | boolean |
259+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isConstantExpression | false | boolean |
260+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
261+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | notASinkReason | ClientRequest | string |
262+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | sinkLabel | NotASink | string |
263+
| index.js:84:12:84:18 | foo.bar | SqlInjection | hasFlowFromSource | false | boolean |
264+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isConstantExpression | false | boolean |
265+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
266+
| index.js:84:12:84:18 | foo.bar | SqlInjection | notASinkReason | ClientRequest | string |
267+
| index.js:84:12:84:18 | foo.bar | SqlInjection | sinkLabel | NotASink | string |
268+
| index.js:84:12:84:18 | foo.bar | TaintedPath | hasFlowFromSource | false | boolean |
269+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isConstantExpression | false | boolean |
270+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
271+
| index.js:84:12:84:18 | foo.bar | TaintedPath | notASinkReason | ClientRequest | string |
272+
| index.js:84:12:84:18 | foo.bar | TaintedPath | sinkLabel | NotASink | string |
273+
| index.js:84:12:84:18 | foo.bar | Xss | hasFlowFromSource | false | boolean |
274+
| index.js:84:12:84:18 | foo.bar | Xss | isConstantExpression | false | boolean |
275+
| index.js:84:12:84:18 | foo.bar | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
276+
| index.js:84:12:84:18 | foo.bar | Xss | notASinkReason | ClientRequest | string |
277+
| index.js:84:12:84:18 | foo.bar | Xss | sinkLabel | NotASink | string |
234278
tokenFeatures
235279
| index.js:1:25:1:33 | "express" | argumentIndex | 0 |
236280
| index.js:1:25:1:33 | "express" | calleeAccessPath | |
@@ -384,3 +428,19 @@ tokenFeatures
384428
| index.js:78:30:78:39 | "someData" | enclosingFunctionBody | console log someData |
385429
| index.js:78:30:78:39 | "someData" | enclosingFunctionName | identity#functionalargument |
386430
| index.js:78:30:78:39 | "someData" | receiverName | console |
431+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | argumentIndex | 0 |
432+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPath | |
433+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPathWithStructuralInfo | |
434+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeApiName | |
435+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeName | ajax |
436+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionBody | foo $ ajax url foo bar |
437+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionName | effectiveSinkAndNotASink |
438+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | receiverName | $ |
439+
| index.js:84:12:84:18 | foo.bar | argumentIndex | |
440+
| index.js:84:12:84:18 | foo.bar | calleeAccessPath | |
441+
| index.js:84:12:84:18 | foo.bar | calleeAccessPathWithStructuralInfo | |
442+
| index.js:84:12:84:18 | foo.bar | calleeApiName | |
443+
| index.js:84:12:84:18 | foo.bar | calleeName | |
444+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionBody | foo $ ajax url foo bar |
445+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionName | effectiveSinkAndNotASink |
446+
| index.js:84:12:84:18 | foo.bar | receiverName | |

‎javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_unit_tests/ExtractEndpointDataTraining.expected

Lines changed: 60 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,50 @@ endpoints
3131
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | NosqlInjection | isConstantExpression | false | boolean |
3232
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
3333
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | NosqlInjection | sinkLabel | Sink | string |
34+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | hasFlowFromSource | false | boolean |
35+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isConstantExpression | false | boolean |
36+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
37+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | ClientRequest | string |
38+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | notASinkReason | JQueryArgument | string |
39+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | NosqlInjection | sinkLabel | NotASink | string |
40+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | hasFlowFromSource | false | boolean |
41+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isConstantExpression | false | boolean |
42+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
43+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | ClientRequest | string |
44+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | notASinkReason | JQueryArgument | string |
45+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | SqlInjection | sinkLabel | NotASink | string |
46+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | hasFlowFromSource | false | boolean |
47+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isConstantExpression | false | boolean |
48+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
49+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | ClientRequest | string |
50+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | notASinkReason | JQueryArgument | string |
51+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | TaintedPath | sinkLabel | NotASink | string |
52+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | hasFlowFromSource | false | boolean |
53+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isConstantExpression | false | boolean |
54+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
55+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | ClientRequest | string |
56+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | notASinkReason | JQueryArgument | string |
57+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | Xss | sinkLabel | NotASink | string |
58+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | hasFlowFromSource | false | boolean |
59+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isConstantExpression | false | boolean |
60+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
61+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | notASinkReason | ClientRequest | string |
62+
| index.js:84:12:84:18 | foo.bar | NosqlInjection | sinkLabel | NotASink | string |
63+
| index.js:84:12:84:18 | foo.bar | SqlInjection | hasFlowFromSource | false | boolean |
64+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isConstantExpression | false | boolean |
65+
| index.js:84:12:84:18 | foo.bar | SqlInjection | isExcludedFromEndToEndEvaluation | false | boolean |
66+
| index.js:84:12:84:18 | foo.bar | SqlInjection | notASinkReason | ClientRequest | string |
67+
| index.js:84:12:84:18 | foo.bar | SqlInjection | sinkLabel | NotASink | string |
68+
| index.js:84:12:84:18 | foo.bar | TaintedPath | hasFlowFromSource | false | boolean |
69+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isConstantExpression | false | boolean |
70+
| index.js:84:12:84:18 | foo.bar | TaintedPath | isExcludedFromEndToEndEvaluation | false | boolean |
71+
| index.js:84:12:84:18 | foo.bar | TaintedPath | notASinkReason | ClientRequest | string |
72+
| index.js:84:12:84:18 | foo.bar | TaintedPath | sinkLabel | NotASink | string |
73+
| index.js:84:12:84:18 | foo.bar | Xss | hasFlowFromSource | false | boolean |
74+
| index.js:84:12:84:18 | foo.bar | Xss | isConstantExpression | false | boolean |
75+
| index.js:84:12:84:18 | foo.bar | Xss | isExcludedFromEndToEndEvaluation | false | boolean |
76+
| index.js:84:12:84:18 | foo.bar | Xss | notASinkReason | ClientRequest | string |
77+
| index.js:84:12:84:18 | foo.bar | Xss | sinkLabel | NotASink | string |
3478
tokenFeatures
3579
| index.js:9:15:9:45 | { 'isAd ... Admin } | argumentIndex | 0 |
3680
| index.js:9:15:9:45 | { 'isAd ... Admin } | calleeAccessPath | mongoose model find |
@@ -64,3 +108,19 @@ tokenFeatures
64108
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | enclosingFunctionBody | User find UNDEFINED_GLOBAL |
65109
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | enclosingFunctionName | notConstantExpression |
66110
| index.js:28:13:28:28 | UNDEFINED_GLOBAL | receiverName | User |
111+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | argumentIndex | 0 |
112+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPath | |
113+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeAccessPathWithStructuralInfo | |
114+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeApiName | |
115+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | calleeName | ajax |
116+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionBody | foo $ ajax url foo bar |
117+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | enclosingFunctionName | effectiveSinkAndNotASink |
118+
| index.js:83:10:85:3 | {\\n " ... ar,\\n } | receiverName | $ |
119+
| index.js:84:12:84:18 | foo.bar | argumentIndex | |
120+
| index.js:84:12:84:18 | foo.bar | calleeAccessPath | |
121+
| index.js:84:12:84:18 | foo.bar | calleeAccessPathWithStructuralInfo | |
122+
| index.js:84:12:84:18 | foo.bar | calleeApiName | |
123+
| index.js:84:12:84:18 | foo.bar | calleeName | |
124+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionBody | foo $ ajax url foo bar |
125+
| index.js:84:12:84:18 | foo.bar | enclosingFunctionName | effectiveSinkAndNotASink |
126+
| index.js:84:12:84:18 | foo.bar | receiverName | |

‎javascript/ql/experimental/adaptivethreatmodeling/test/endpoint_unit_tests/index.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,3 +77,10 @@ function veryLongFunctionBody() {
7777
// We should name the anonymous function here that's passed as an argument to `identity`.
7878
identity(() => console.log("someData"));
7979
}
80+
81+
82+
function effectiveSinkAndNotASink(foo) {
83+
$.ajax({
84+
"url": foo.bar,
85+
});
86+
}

0 commit comments

Comments
 (0)