Ruby: Replace Receiver with Argument[self]

Author: asgerf

ruby/ql/lib/codeql/ruby/dataflow/internal/FlowSummaryImplSpecific.qll

@@ -59,9 +59,6 @@ predicate summaryElement(DataFlowCallable c, string input, string output, string
  */
 bindingset[c]
 SummaryComponent interpretComponentSpecific(AccessPathToken c) {
-  c = "Receiver" and // TODO: replace with Argument[self]
-  result = FlowSummary::SummaryComponent::receiver()
-  or
   c = "Argument[_]" and
   result = FlowSummary::SummaryComponent::argument(any(ParameterPosition pos | pos.isPositional(_)))
   or

ruby/ql/lib/codeql/ruby/frameworks/ActiveStorage.qll

@@ -24,7 +24,7 @@ private class Summaries extends ModelInput::SummaryModelCsv {
     row =
       [
         "activestorage;;Member[ActiveStorage].Member[Filename].Method[new];Argument[0];ReturnValue;taint",
-        "activestorage;;Member[ActiveStorage].Member[Filename].Instance.Method[sanitized];Receiver;ReturnValue;taint",
+        "activestorage;;Member[ActiveStorage].Member[Filename].Instance.Method[sanitized];Argument[self];ReturnValue;taint",
       ]
   }
 }

ruby/ql/lib/codeql/ruby/frameworks/Core.qll

@@ -61,11 +61,11 @@ private class SplatSummary extends SummarizedCallable {
   override predicate propagatesFlowExt(string input, string output, boolean preservesValue) {
     (
       // *1 = [1]
-      input = "Receiver" and
+      input = "Argument[self]" and
       output = "ReturnValue.ArrayElement[0]"
       or
       // *[1] = [1]
-      input = "Receiver" and
+      input = "Argument[self]" and
       output = "ReturnValue"
     ) and
     preservesValue = true