Ruby: Make getFormatArgument 0-indexed

hmac · hmac · commit c253bddbe0d8 · 2022-03-21T12:51:47.000+13:00
diff --git a/ruby/ql/lib/codeql/ruby/security/TaintedFormatStringSpecific.qll b/ruby/ql/lib/codeql/ruby/security/TaintedFormatStringSpecific.qll
@@ -21,7 +21,7 @@ abstract class PrintfStyleCall extends DataFlow::CallNode {
   /**
    * Gets then `n`th formatted argument of this call.
    */
-  DataFlow::Node getFormatArgument(int n) { n > 0 and result = this.getArgument(n) }
+  DataFlow::Node getFormatArgument(int n) { n >= 0 and result = this.getArgument(n + 1) }
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ abstract class PrintfStyleCall extends DataFlow::CallNode {`
`21`	`21`	`/**`
`22`	`22`	* Gets then `n`th formatted argument of this call.
`23`	`23`	`*/`
`24`		`- DataFlow::Node getFormatArgument(int n) { n > 0 and result = this.getArgument(n) }`
	`24`	`+ DataFlow::Node getFormatArgument(int n) { n >= 0 and result = this.getArgument(n + 1) }`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`/**`