fix a ql/field-only-used-in-charpred warning

erik-krogh · erik-krogh · commit bdfd6bdc7907 · 2022-04-07T13:52:14.000+02:00
diff --git a/python/ql/lib/semmle/python/frameworks/Flask.qll b/python/ql/lib/semmle/python/frameworks/Flask.qll
@@ -403,11 +403,8 @@ module Flask {
   }
 
   private class RequestAttrMultiDict extends Werkzeug::MultiDict::InstanceSource {
-    string attr_name;
-
     RequestAttrMultiDict() {
-      this = request().getMember(attr_name).getAnImmediateUse() and
-      attr_name in ["args", "values", "form", "files"]
+      this = request().getMember(["args", "values", "form", "files"]).getAnImmediateUse()
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -403,11 +403,8 @@ module Flask {`
`403`	`403`	`}`
`404`	`404`
`405`	`405`	`private class RequestAttrMultiDict extends Werkzeug::MultiDict::InstanceSource {`
`406`		`- string attr_name;`
`407`		`-`
`408`	`406`	`RequestAttrMultiDict() {`
`409`		`- this = request().getMember(attr_name).getAnImmediateUse() and`
`410`		`- attr_name in ["args", "values", "form", "files"]`
	`407`	`+ this = request().getMember(["args", "values", "form", "files"]).getAnImmediateUse()`
`411`	`408`	`}`
`412`	`409`	`}`
`413`	`410`