added casting

Jami Cogswell · Jami Cogswell · commit b779f9f935df · 2022-08-15T15:50:00.000-04:00
diff --git a/java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.ql b/java/ql/src/Security/CWE/CWE-489/DebuggableAttributeEnabled.ql
@@ -16,5 +16,5 @@ import semmle.code.xml.AndroidManifest
 from AndroidApplicationXmlElement androidAppElem
 where
   androidAppElem.isDebuggable() and
-  not androidAppElem.getFile().isInBuildDirectory()
+  not androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory()
 select androidAppElem.getAttribute("debuggable"), "The 'android:debuggable' attribute is enabled."
diff --git a/java/ql/test/query-tests/security/CWE-489/DebuggableAttributeEnabledTest.ql b/java/ql/test/query-tests/security/CWE-489/DebuggableAttributeEnabledTest.ql
@@ -11,7 +11,7 @@ class DebuggableAttributeEnabledTest extends InlineExpectationsTest {
     tag = "hasDebuggableAttributeEnabled" and
     exists(AndroidApplicationXmlElement androidAppElem |
       androidAppElem.isDebuggable() and
-      not androidAppElem.getFile().isInBuildDirectory()
+      not androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory()
     |
       androidAppElem.getAttribute("debuggable").getLocation() = location and
       element = androidAppElem.getAttribute("debuggable").toString() and

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ class DebuggableAttributeEnabledTest extends InlineExpectationsTest {`
`11`	`11`	`tag = "hasDebuggableAttributeEnabled" and`
`12`	`12`	`exists(AndroidApplicationXmlElement androidAppElem \|`
`13`	`13`	`androidAppElem.isDebuggable() and`
`14`		`- not androidAppElem.getFile().isInBuildDirectory()`
	`14`	`+ not androidAppElem.getFile().(AndroidManifestXmlFile).isInBuildDirectory()`
`15`	`15`	`\|`
`16`	`16`	`androidAppElem.getAttribute("debuggable").getLocation() = location and`
`17`	`17`	`element = androidAppElem.getAttribute("debuggable").toString() and`