Python: less eager tracking of flow

yoff · yoff · commit b1ae3bfdb2fc · 2022-09-28T11:46:26.000+02:00
diff --git a/python/ql/lib/semmle/python/frameworks/Flask.qll b/python/ql/lib/semmle/python/frameworks/Flask.qll
@@ -421,9 +421,7 @@ module Flask {
 
   /** An `FileStorage` instance that originates from a flask request. */
   private class FlaskRequestFileStorageInstances extends Werkzeug::FileStorage::InstanceSource {
-    FlaskRequestFileStorageInstances() {
-      this = requestFileStorage().getAValueReachableFromSource()
-    }
+    FlaskRequestFileStorageInstances() { this = requestFileStorage().asSource() }
   }
 
   /** An `Headers` instance that originates from a flask request. */

Original file line number	Diff line number	Diff line change
`@@ -421,9 +421,7 @@ module Flask {`
`421`	`421`
`422`	`422`	/** An `FileStorage` instance that originates from a flask request. */
`423`	`423`	`private class FlaskRequestFileStorageInstances extends Werkzeug::FileStorage::InstanceSource {`
`424`		`- FlaskRequestFileStorageInstances() {`
`425`		`- this = requestFileStorage().getAValueReachableFromSource()`
`426`		`- }`
	`424`	`+ FlaskRequestFileStorageInstances() { this = requestFileStorage().asSource() }`
`427`	`425`	`}`
`428`	`426`
`429`	`427`	/** An `Headers` instance that originates from a flask request. */