Skip to content

Commit afadcd9

Browse files
committed
use a more detailed alert message in bitwise-sign-check
1 parent d96d672 commit afadcd9

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

cpp/ql/src/Likely Bugs/Arithmetic/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ where
2525
forall(int op | op = lhs.(BitwiseAndExpr).getAnOperand().getValue().toInt() | op < 0) and
2626
// exception for cases involving macros
2727
not e.isAffectedByMacro()
28-
select e, "Sign check of a bitwise operation."
28+
select e, "Potential unsafe sign check of a bitwise operation."

java/ql/src/Likely Bugs/Comparison/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ where
1616
e.isStrict() and
1717
e.getGreaterOperand() instanceof BitwiseExpr and
1818
e.getLesserOperand().(IntegerLiteral).getIntValue() = 0
19-
select e, "Sign check of a bitwise operation."
19+
select e, "Potential unsafe sign check of a bitwise operation."

javascript/ql/src/Expressions/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ where
5353
not e instanceof EqualityTest and
5454
e.getRightOperand().getIntValue() = 0 and
5555
not acceptableSignCheck(b)
56-
select e, "Sign check of a bitwise operation."
56+
select e, "Potential unsafe sign check of a bitwise operation."

0 commit comments

Comments
 (0)