python: only clear taint on false-edge

yoff · web-flow · commit ac0c8d238f3c · 2022-06-28T20:14:52.000Z
diff --git a/python/ql/lib/semmle/python/security/dataflow/TarSlipCustomizations.qll b/python/ql/lib/semmle/python/security/dataflow/TarSlipCustomizations.qll
@@ -131,7 +131,7 @@ module TarSlip {
       or
       call.getAChild*().(NameNode).getId().matches("%path")
     ) and
-    branch in [true, false]
+    branch = false
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ module TarSlip {`
`131`	`131`	`or`
`132`	`132`	`call.getAChild*().(NameNode).getId().matches("%path")`
`133`	`133`	`) and`
`134`		`- branch in [true, false]`
	`134`	`+ branch = false`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`/**`