Skip to content

Commit abf894a

Browse files
Fix typos
1 parent 03c2a0e commit abf894a

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

java/ql/lib/semmle/code/java/security/AndroidWebViewCertificateValidationQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/** Defintions for the web view certificate validation query */
1+
/** Definitions for the web view certificate validation query */
22

33
import java
44

@@ -28,7 +28,7 @@ private class SslProceedCall extends MethodAccess {
2828
}
2929
}
3030

31-
/** Holds if `m` trusts all certifiates by calling `SslErrorHandler.proceed` unconditionally. */
31+
/** Holds if `m` trusts all certificates by calling `SslErrorHandler.proceed` unconditionally. */
3232
predicate trustsAllCerts(OnReceivedSslErrorMethod m) {
3333
exists(SslProceedCall pr | pr.getQualifier().(VarAccess).getVariable() = m.handlerArg()) and
3434
not exists(SslCancelCall ca | ca.getQualifier().(VarAccess).getVariable() = m.handlerArg())

java/ql/src/Security/CWE/CWE-295/ImproperWebViewCertifiacteValidation.qhelp renamed to java/ql/src/Security/CWE/CWE-295/ImproperWebViewCertificateValidation.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ An attack might look like this:
2424

2525
<recommendation>
2626
<p>
27-
Do not use a call <code>SslerrorHandler.proceed</code> unconditonally.
27+
Do not use a call <code>SslerrorHandler.proceed</code> unconditionally.
2828
If you have to use a self-signed certificate, only accept that certificate, not all certificates.
2929
</p>
3030

java/ql/src/Security/CWE/CWE-295/ImproperWebViewCertificateValidation.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* @name Android `WebVeiw` that accepts all certificates
2+
* @name Android `WebView` that accepts all certificates
33
* @description Trusting all certificates allows an attacker to perform a machine-in-the-middle attack.
44
* @kind problem
55
* @problem.severity error
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
---
22
category: newQuery
33
---
4-
* A new query "Android `WebVeiw` that accepts all certificates" (`java/improper-webview-certificate-validation`) has been added. This query finds implementations of `WebViewClient`s that accept all certificates in the case of an SSL error.
4+
* A new query "Android `WebView` that accepts all certificates" (`java/improper-webview-certificate-validation`) has been added. This query finds implementations of `WebViewClient`s that accept all certificates in the case of an SSL error.

0 commit comments

Comments
 (0)