C++: exclude 0 earlier in InsufficientKeySize

rdmarsh2 · rdmarsh2 · commit a60fe9f4b845 · 2022-02-24T14:26:37.000-05:00
diff --git a/cpp/ql/src/Security/CWE/CWE-326/InsufficientKeySize.ql b/cpp/ql/src/Security/CWE/CWE-326/InsufficientKeySize.ql
@@ -31,7 +31,7 @@ class KeyStrengthFlow extends DataFlow::Configuration {
   KeyStrengthFlow() { this = "KeyStrengthFlow" }
 
   override predicate isSource(DataFlow::Node node) {
-    node.asInstruction() instanceof IntegerConstantInstruction
+    node.asInstruction().(IntegerConstantInstruction).getValue() != "0"
   }
 
   override predicate isSink(DataFlow::Node node) {

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@ class KeyStrengthFlow extends DataFlow::Configuration {`
`31`	`31`	`KeyStrengthFlow() { this = "KeyStrengthFlow" }`
`32`	`32`
`33`	`33`	`override predicate isSource(DataFlow::Node node) {`
`34`		`- node.asInstruction() instanceof IntegerConstantInstruction`
	`34`	`+ node.asInstruction().(IntegerConstantInstruction).getValue() != "0"`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`override predicate isSink(DataFlow::Node node) {`