Skip to content

Commit a50234a

Browse files
committed
apply suggestion from review
1 parent 1a7d3ee commit a50234a

File tree

5 files changed

+10
-10
lines changed

5 files changed

+10
-10
lines changed

cpp/ql/src/Likely Bugs/Arithmetic/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,4 +25,4 @@ where
2525
forall(int op | op = lhs.(BitwiseAndExpr).getAnOperand().getValue().toInt() | op < 0) and
2626
// exception for cases involving macros
2727
not e.isAffectedByMacro()
28-
select e, "Potential unsafe sign check of a bitwise operation."
28+
select e, "Potentially unsafe sign check of a bitwise operation."
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
| bsc.cpp:2:10:2:32 | ... > ... | Potential unsafe sign check of a bitwise operation. |
2-
| bsc.cpp:6:10:6:32 | ... > ... | Potential unsafe sign check of a bitwise operation. |
3-
| bsc.cpp:18:10:18:28 | ... > ... | Potential unsafe sign check of a bitwise operation. |
4-
| bsc.cpp:22:10:22:28 | ... < ... | Potential unsafe sign check of a bitwise operation. |
1+
| bsc.cpp:2:10:2:32 | ... > ... | Potentially unsafe sign check of a bitwise operation. |
2+
| bsc.cpp:6:10:6:32 | ... > ... | Potentially unsafe sign check of a bitwise operation. |
3+
| bsc.cpp:18:10:18:28 | ... > ... | Potentially unsafe sign check of a bitwise operation. |
4+
| bsc.cpp:22:10:22:28 | ... < ... | Potentially unsafe sign check of a bitwise operation. |

java/ql/src/Likely Bugs/Comparison/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ where
1616
e.isStrict() and
1717
e.getGreaterOperand() instanceof BitwiseExpr and
1818
e.getLesserOperand().(IntegerLiteral).getIntValue() = 0
19-
select e, "Potential unsafe sign check of a bitwise operation."
19+
select e, "Potentially unsafe sign check of a bitwise operation."

javascript/ql/src/Expressions/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ where
5353
not e instanceof EqualityTest and
5454
e.getRightOperand().getIntValue() = 0 and
5555
not acceptableSignCheck(b)
56-
select e, "Potential unsafe sign check of a bitwise operation."
56+
select e, "Potentially unsafe sign check of a bitwise operation."
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
| tst.js:2:9:2:24 | (x & (1<<n)) > 0 | Potential unsafe sign check of a bitwise operation. |
2-
| tst.js:14:13:14:25 | (x >>> 0) > 0 | Potential unsafe sign check of a bitwise operation. |
3-
| tst.js:23:1:23:21 | (x & 0x ... 00) > 0 | Potential unsafe sign check of a bitwise operation. |
1+
| tst.js:2:9:2:24 | (x & (1<<n)) > 0 | Potentially unsafe sign check of a bitwise operation. |
2+
| tst.js:14:13:14:25 | (x >>> 0) > 0 | Potentially unsafe sign check of a bitwise operation. |
3+
| tst.js:23:1:23:21 | (x & 0x ... 00) > 0 | Potentially unsafe sign check of a bitwise operation. |

0 commit comments

Comments
 (0)