Skip to content

Commit a2245bb

Browse files
Fix test
1 parent 498ad23 commit a2245bb

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

java/ql/lib/semmle/code/java/security/AndroidWebViewCertificateValidationQuery.qll

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@ import java
22

33
class OnReceivedSslErrorMethod extends Method {
44
OnReceivedSslErrorMethod() {
5-
this.hasQualifiedName("android.webkit", "WebViewClient", "onReceivedSslError")
5+
this.overrides*(any(Method m |
6+
m.hasQualifiedName("android.webkit", "WebViewClient", "onReceivedSslError")
7+
))
68
}
79

810
Parameter handlerArg() { result = this.getParameter(1) }

java/ql/test/query-tests/security/CWE-295/ImproperWebVeiwCertificateValidation/Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@
99

1010
class Test {
1111
class A extends WebViewClient {
12-
public void onReceivedSslError (WebView view, SslErrorHandler handler, SslError error) {
13-
handler.proceed(); // $hasResult
12+
public void onReceivedSslError (WebView view, SslErrorHandler handler, SslError error) { // $hasResult
13+
handler.proceed();
1414
}
1515
}
1616

0 commit comments

Comments
 (0)