Skip to content

Commit a040b67

Browse files
committed
Ruby: drop some redundant extends classes
1 parent d85424d commit a040b67

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

ruby/ql/lib/codeql/ruby/frameworks/ActiveRecord.qll

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -415,7 +415,7 @@ private module Persistence {
415415
}
416416

417417
/** A call to e.g. `user.update(name: "foo")` */
418-
private class UpdateLikeInstanceMethodCall extends DataFlow::CallNode, PersistentWriteAccess::Range,
418+
private class UpdateLikeInstanceMethodCall extends PersistentWriteAccess::Range,
419419
ActiveRecordInstanceMethodCall {
420420
UpdateLikeInstanceMethodCall() {
421421
this.getMethodName() = ["update", "update!", "update_attributes", "update_attributes!"]
@@ -431,7 +431,8 @@ private module Persistence {
431431
}
432432

433433
/** A call to e.g. `user.update_attribute(name, "foo")` */
434-
private class UpdateAttributeCall extends DataFlow::CallNode, PersistentWriteAccess::Range, ActiveRecordInstanceMethodCall {
434+
private class UpdateAttributeCall extends PersistentWriteAccess::Range,
435+
ActiveRecordInstanceMethodCall {
435436
UpdateAttributeCall() { this.getMethodName() = "update_attribute" }
436437

437438
override DataFlow::Node getValue() {
@@ -446,7 +447,7 @@ private module Persistence {
446447
* as an `PersistentWriteAccess` to avoid missing cases where the path to a
447448
* subsequent write is not clear.
448449
*/
449-
private class AssignAttribute extends DataFlow::Node, PersistentWriteAccess::Range {
450+
private class AssignAttribute extends PersistentWriteAccess::Range {
450451
private ExprNodes::AssignExprCfgNode assignNode;
451452

452453
AssignAttribute() {

0 commit comments

Comments
 (0)